Help to correct my scalping code

[mcarlbenjamin]

HI GUYS, HELP CORRECT MY CODE:

//+------------------------------------------------------------------+
//|                        Scalping Script                           |
//|              Expert Advisor for MT5 Platform                     |
//|                                                                  |
//|        Copyright 2023, Carl                                |
//|        https://www.yourwebsite.com                               |
//+------------------------------------------------------------------+
#property copyright "Copyright 2023, Carl"
#property link      "https://www.yourwebsite.com"
#property version   "1.00"

// Input parameters
input double LotsMin = 0.1;          // Minimum lot size
input double LotsMax = 10.0;         // Maximum lot size
input double StopLoss = 20.0;        // Stop loss in pips
input double TakeProfit = 40.0;      // Take profit in pips
input bool UseTrailingStop = true;   // Enable trailing stop
input int TrailingStop = 20;         // Trailing stop value in pips

// Money management
double BalanceMin = 10.0;            // Minimum account balance to trade
double RiskPercent = 1.0;            // Risk percentage per trade

// Price action parameters
int SignalIndicatorPeriod = 14;      // Period for the signal indicator
double SignalIndicatorLevel = 0.5;   // Level for the signal indicator

// Global variables
double AccountBalance;
double RiskAmount;

//+------------------------------------------------------------------+
//| Expert advisor start function                                     |
//+------------------------------------------------------------------+
void OnTick()
{
    // Check if enough funds are available
    AccountBalance = AccountInfoDouble(ACCOUNT_BALANCE);
    if (AccountBalance < BalanceMin)
        return;

    // Calculate risk amount per trade
    RiskAmount = AccountBalance * RiskPercent / 100.0;

    // Loop through available symbols
    for (int i = 0; i < SymbolsTotal(); i++)
    {
        string symbol = SymbolName(i, false);
        
        // Apply your smart money and price action strategies here
        // Determine the price action signal based on your strategy
        int signal = GetPriceActionSignal(symbol);
        
        // Open a trade if signal is valid
        if (signal > 0)
        {
            double lotSize = NormalizeDouble(RiskAmount / StopLoss / MarketInfo(symbol, MODE_TICKVALUE), 2);
            lotSize = MathMax(LotsMin, MathMin(lotSize, LotsMax));

            // Calculate stop loss and take profit levels
            double stopLossLevel = Ask - StopLoss * MarketInfo(symbol, MODE_POINT);
            double takeProfitLevel = Ask + TakeProfit * MarketInfo(symbol, MODE_POINT);

            // Open an instant execution trade
            int ticket = OrderSend(symbol, OP_BUY, lotSize, Ask, 0, stopLossLevel, takeProfitLevel, "Scalping", 0, 0, Green);
            
            // Apply trailing stop if enabled
            if (UseTrailingStop && ticket > 0)
                OrderModify(ticket, 0, stopLossLevel, takeProfitLevel, 0, Green);
        }
    }
}

// Custom function to determine the price action signal
int GetPriceActionSignal(string symbol)
{
    // Define variables for price action analysis
    double previousHigh = High[Highest(NULL, 0, MODE_HIGH, SignalIndicatorPeriod, 1)];
    double previousLow = Low[Lowest(NULL, 0, MODE_LOW, SignalIndicatorPeriod, 1)];
    double currentHigh = High[0];
    double currentLow = Low[0];
    
    // Check for bullish engulfing pattern
    bool bullishEngulfing = currentHigh > previousHigh && currentLow < previousLow && Close[0] > Open[0] && Open[1] > Close[1];
    
    // Check for bearish engulfing pattern
    bool bearishEngulfing = currentHigh > previousHigh && currentLow < previousLow && Close[0] < Open[0] && Open[1] < Close[1];
    
    // Check for support/resistance breakout
    double resistanceLevel = GetResistanceLevel(symbol);
    double supportLevel = GetSupportLevel(symbol);
    
    bool breakoutAboveResistance = currentHigh > resistanceLevel && previousHigh < resistanceLevel;
    bool breakoutBelowSupport = currentLow < supportLevel && previousLow > supportLevel;
    
    // Check for uptrend and downtrend
    bool uptrend = currentHigh > previousHigh && currentLow > previousLow;
    bool downtrend = currentHigh < previousHigh && currentLow < previousLow;
    
    // Determine the price action signal
    int signal = 0;
    
    if (bullishEngulfing && uptrend)
        signal = 1; // Buy signal
    else if (bearishEngulfing && downtrend)
        signal = -1; // Sell signal
    else if (breakoutAboveResistance)
        signal = 1; // Buy signal
    else if (breakoutBelowSupport)
        signal = -1; // Sell signal
    
    return signal;
}

// Custom function to calculate resistance level
double GetResistanceLevel(string symbol)
{
    // Define your logic to calculate the resistance level
    // Example: return the previous day's high
    double resistanceLevel = High[Highest(NULL, 0, MODE_HIGH, SignalIndicatorPeriod, 1)];
    return resistanceLevel;
}

// Custom function to calculate support level
double GetSupportLevel(string symbol)
{
    // Define your logic to calculate the support level
    // Example: return the previous day's low
    double supportLevel = Low[Lowest(NULL, 0, MODE_LOW, SignalIndicatorPeriod, 1)];
    return supportLevel;
}

[kenorb]

Have you tried GPT? What's the issue with the code?

GPT suggestions:

• Change SymbolsTotal() to SymbolsTotal(false) to avoid counting synthetic symbols.
• Add a condition to check if signal is not equal to 0 before opening a trade, currently you have only support for buy orders.
• Correct the calculation of resistance and support levels in the GetResistanceLevel() and GetSupportLevel() functions by specifying the timeframe PERIOD_D1.
• Update the GetResistanceLevel() and GetSupportLevel() functions to use the symbol parameter when calling Highest() and Lowest() functions.

[mcarlbenjamin]

gbt also failed to correct the code.... i wish someone can help me out
its an MQL5 script.
an EA advisor thats supposed to work on meta 5

[kenorb]

Try asking at Stack Overflow, just clarify what doesn't work. I can help only with the code related to EA31337, and your code isn't related much to it, sorry. Unless you're planning to integrate it somehow into the existing codebase, so please clarify.