From b90380211c4cdd6553346595171c4795caf74525 Mon Sep 17 00:00:00 2001 From: Andrija Kolic Date: Sun, 19 Jan 2025 16:55:30 +0100 Subject: [PATCH] Update to startup phase with iterations (stabilized time-to-first-response). --- compiler/ci/ci_common/benchmark-suites.libsonnet | 2 +- substratevm/mx.substratevm/mx_substratevm_benchmark.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/compiler/ci/ci_common/benchmark-suites.libsonnet b/compiler/ci/ci_common/benchmark-suites.libsonnet index 261646a9b14c..e2b767f946f6 100644 --- a/compiler/ci/ci_common/benchmark-suites.libsonnet +++ b/compiler/ci/ci_common/benchmark-suites.libsonnet @@ -117,7 +117,7 @@ barista_template(suite_version=null, suite_name="barista", max_jdk_version=null, cmd_app_prefix=["hwloc-bind --cpubind node:0.core:0-3.pu:0 --membind node:0"], non_prefix_barista_args=[]):: cc.compiler_benchmark + { suite:: suite_name, - local barista_version = "v0.3.0", + local barista_version = "v0.3.3", local suite_version_args = if suite_version != null then ["--bench-suite-version=" + suite_version] else [], local prefix_barista_arg = if std.length(cmd_app_prefix) > 0 then [std.format("--cmd-app-prefix=%s", std.join(" ", cmd_app_prefix))] else [], local all_barista_args = prefix_barista_arg + non_prefix_barista_args, diff --git a/substratevm/mx.substratevm/mx_substratevm_benchmark.py b/substratevm/mx.substratevm/mx_substratevm_benchmark.py index f36649d9e9fb..b021b6305b0b 100644 --- a/substratevm/mx.substratevm/mx_substratevm_benchmark.py +++ b/substratevm/mx.substratevm/mx_substratevm_benchmark.py @@ -391,6 +391,7 @@ def _short_load_testing_phases(self): Useful for the `agent` and `instrument-run` stages. """ return [ + "--startup-iteration-count", "1", "--warmup-iteration-count", "1", "--warmup-duration", "5", "--throughput-iteration-count", "0", @@ -465,6 +466,8 @@ def produceHarnessCommand(self, cmd, suite): if stage == mx_sdk_benchmark.Stage.INSTRUMENT_RUN: # Make instrument run short ni_barista_cmd += self._short_load_testing_phases() + if suite.context.benchmark == "play-scala-hello-world": + self._updateCommandOption(ni_barista_cmd, "--vm-options", "-v", "-Dpidfile.path=/dev/null") # Add explicit instrument stage args ni_barista_cmd += mx_sdk_benchmark.parse_prefixed_args("-Dnative-image.benchmark.extra-profile-run-arg=", suite.context.bmSuiteArgs) or mx_sdk_benchmark.parse_prefixed_args("-Dnative-image.benchmark.extra-run-arg=", suite.context.bmSuiteArgs) else: