From e04eca81e63a10796844edad8bdd159967d915a2 Mon Sep 17 00:00:00 2001 From: Boris Glimcher Date: Wed, 12 Apr 2023 16:19:09 +0300 Subject: [PATCH] code review: improve error message Signed-off-by: Boris Glimcher --- pkg/backend/aio_test.go | 2 +- pkg/backend/null_test.go | 2 +- pkg/backend/nvme_test.go | 2 +- pkg/frontend/blk_test.go | 2 +- pkg/frontend/nvme_test.go | 4 ++-- pkg/middleend/middleend_test.go | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/pkg/backend/aio_test.go b/pkg/backend/aio_test.go index cfd00216..e59a318f 100644 --- a/pkg/backend/aio_test.go +++ b/pkg/backend/aio_test.go @@ -386,7 +386,7 @@ func TestBackEnd_ListAioControllers(t *testing.T) { } // Empty NextPageToken indicates end of results list if tt.size != 1 && response.NextPageToken != "" { - t.Error("response: expected", tt, "received", response) + t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken) } } diff --git a/pkg/backend/null_test.go b/pkg/backend/null_test.go index 6c7cc430..07a7e024 100644 --- a/pkg/backend/null_test.go +++ b/pkg/backend/null_test.go @@ -390,7 +390,7 @@ func TestBackEnd_ListNullDebugs(t *testing.T) { } // Empty NextPageToken indicates end of results list if tt.size != 1 && response.NextPageToken != "" { - t.Error("response: expected", tt, "received", response) + t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken) } } diff --git a/pkg/backend/nvme_test.go b/pkg/backend/nvme_test.go index b26aee7e..d034684f 100644 --- a/pkg/backend/nvme_test.go +++ b/pkg/backend/nvme_test.go @@ -339,7 +339,7 @@ func TestBackEnd_ListNVMfRemoteControllers(t *testing.T) { } // Empty NextPageToken indicates end of results list if tt.size != 1 && response.NextPageToken != "" { - t.Error("response: expected", tt, "received", response) + t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken) } } diff --git a/pkg/frontend/blk_test.go b/pkg/frontend/blk_test.go index 30abb424..9ca46149 100644 --- a/pkg/frontend/blk_test.go +++ b/pkg/frontend/blk_test.go @@ -292,7 +292,7 @@ func TestFrontEnd_ListVirtioBlks(t *testing.T) { } // Empty NextPageToken indicates end of results list if tt.size != 1 && response.NextPageToken != "" { - t.Error("response: expected", tt, "received", response) + t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken) } } diff --git a/pkg/frontend/nvme_test.go b/pkg/frontend/nvme_test.go index 75192142..8c542782 100644 --- a/pkg/frontend/nvme_test.go +++ b/pkg/frontend/nvme_test.go @@ -378,7 +378,7 @@ func TestFrontEnd_ListNVMeSubsystem(t *testing.T) { } // Empty NextPageToken indicates end of results list if tt.size != 1 && response.NextPageToken != "" { - t.Error("response: expected", tt, "received", response) + t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken) } } @@ -1365,7 +1365,7 @@ func TestFrontEnd_ListNVMeNamespaces(t *testing.T) { } // Empty NextPageToken indicates end of results list if tt.size != 1 && response.NextPageToken != "" { - t.Error("response: expected", tt, "received", response) + t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken) } } diff --git a/pkg/middleend/middleend_test.go b/pkg/middleend/middleend_test.go index 291c97af..ec33167e 100644 --- a/pkg/middleend/middleend_test.go +++ b/pkg/middleend/middleend_test.go @@ -551,7 +551,7 @@ func TestMiddleEnd_ListEncryptedVolumes(t *testing.T) { } // Empty NextPageToken indicates end of results list if tt.size != 1 && response.NextPageToken != "" { - t.Error("response: expected", tt, "received", response) + t.Error("Expected end of results, receieved non-empty next page token", response.NextPageToken) } }