Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bmc_fw_update): move vars to argument_specs #46

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Feb 28, 2024

Fixed #37

Signed-off-by: Boris Glimcher [email protected]

@glimchb glimchb added the help wanted Extra attention is needed label Feb 28, 2024
@glimchb glimchb removed the help wanted Extra attention is needed label Feb 29, 2024
@glimchb glimchb marked this pull request as ready for review February 29, 2024 15:16
@glimchb glimchb requested a review from a team as a code owner February 29, 2024 15:16
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Feb 29, 2024
@glimchb glimchb requested a review from jcastanos2 March 1, 2024 16:22
Copy link
Contributor

@jcastanos2 jcastanos2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine. Let's merge

@glimchb glimchb merged commit eb61c45 into opiproject:main Mar 1, 2024
37 of 40 checks passed
@glimchb glimchb deleted the vars branch March 1, 2024 16:39
@jcastanos2
Copy link
Contributor

see an error on the verify. Let me take another look at this after a few calls

@glimchb
Copy link
Member Author

glimchb commented Mar 1, 2024

see an error on the verify. Let me take another look at this after a few calls

fixed here 485b26c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bmc_fw_update: move vars to argument_specs
2 participants