Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bmc_fw_update): compare version with filename #35

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Feb 26, 2024

This is instead of comparing before and after version

Fixes #22

before the fix:

2024-02-27 00:19:40 TASK [bmc_fw_update : Print BMC Version] ***************************************
2024-02-27 00:19:40 task path: /home/boris/ansible-opi-dpu/roles/bmc_fw_update/tasks/main.yml:81
2024-02-27 00:19:40 ok: [10.10.10.1] => {
2024-02-27 00:19:40     "msg": [
2024-02-27 00:19:40         "BF-23.10-5"
2024-02-27 00:19:40     ]
2024-02-27 00:19:40 }
2024-02-27 00:19:40
2024-02-27 00:19:40 TASK [bmc_fw_update : Validate fw image changed from before] *******************
2024-02-27 00:19:40 task path: /home/boris/ansible-opi-dpu/roles/bmc_fw_update/tasks/main.yml:85
2024-02-27 00:19:40 fatal: [10.10.10.1]: FAILED! => {
2024-02-27 00:19:40     "msg": "The conditional check 'get_bmc_facts_before.redfish_facts.firmware.entries[0].Version != get_bmc_facts_after.redfish_facts.firmware.entries[0].Version' failed. The error was: error while evaluating conditional (get_bmc_facts_before.redfish_facts.firmware.entries[0].Version != get_bmc_facts_after.redfish_facts.firmware.entries[0].Version): 'dict object' has no attribute 'redfish_facts'. 'dict object' has no attribute 'redfish_facts'"
2024-02-27 00:19:40 }
2024-02-27 00:19:40

Signed-off-by: Boris Glimcher [email protected]

@glimchb glimchb marked this pull request as ready for review February 26, 2024 19:48
@glimchb glimchb requested a review from a team as a code owner February 26, 2024 19:48
This is instead of comparing before and after version

Fixes opiproject#22

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Feb 28, 2024
@glimchb glimchb merged commit 5b38fca into opiproject:main Feb 29, 2024
37 of 40 checks passed
@glimchb glimchb deleted the assert branch March 1, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bmc_fw_update: use failed_when and changed_when
2 participants