Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user/pass/token: make task names and block names match #70

Closed
glimchb opened this issue Apr 7, 2024 · 0 comments · Fixed by #74
Closed

user/pass/token: make task names and block names match #70

glimchb opened this issue Apr 7, 2024 · 0 comments · Fixed by #74
Labels
good first issue Good for newcomers

Comments

@glimchb
Copy link
Member

glimchb commented Apr 7, 2024

reported by @jcastanos2 on #67

for example:

- name: Reboot BMC when username and password are defined
  when: dpu_bmc_username is defined and dpu_bmc_password is defined
  block:
    - name: Reboot BMC to apply new firmware of DPU
      community.general.redfish_command:

and

- name: Reboot BMC when auth_token is defined
  when: dpu_bmc_token is defined
  block:
    - name: Reboot BMC to apply new firmware of DPU
      community.general.redfish_command:

the block name distinguishes between user/pass and token
but following task name doesn't

from the run log it is not clear which method was used inside the role...

please align...

@glimchb glimchb added the good first issue Good for newcomers label Apr 10, 2024
jcastanos2 added a commit to jcastanos2/ansible-opi-dpu that referenced this issue Apr 11, 2024
jcastanos2 added a commit to jcastanos2/ansible-opi-dpu that referenced this issue Apr 11, 2024
…names match (more blocks)

Signed-off-by: Jose Castanos <[email protected]>
@glimchb glimchb linked a pull request Apr 12, 2024 that will close this issue
glimchb pushed a commit that referenced this issue Apr 12, 2024
glimchb pushed a commit that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
1 participant