Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix maven branch compile error. #1

Open
carlwilson opened this issue Oct 18, 2013 · 1 comment
Open

Fix maven branch compile error. #1

carlwilson opened this issue Oct 18, 2013 · 1 comment

Comments

@carlwilson
Copy link
Member

Maven output below, it's probably an easy fix but am concentrating on getting the pieces in place at the moment.

[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/travis/build/carlwilson/fits/src/test/java/edu/harvard/hul/ois/fits/junit/FitsBasicTest.java:[22,17] package org.junit does not exist
[ERROR] /home/travis/build/carlwilson/fits/src/test/java/edu/harvard/hul/ois/fits/junit/FitsBasicTest.java:[31,8] cannot access junit.framework.TestCase
  class file for junit.framework.TestCase not found
[ERROR] /home/travis/build/carlwilson/fits/src/test/java/edu/harvard/hul/ois/fits/junit/FitsBasicTest.java:[34,10] cannot find symbol
  symbol:   class Test
  location: class edu.harvard.hul.ois.fits.junit.FitsBasicTest
[ERROR] /home/travis/build/carlwilson/fits/src/test/java/edu/harvard/hul/ois/fits/junit/FitsBasicTest.java:[37,31] cannot find symbol
  symbol:   variable this
  location: class edu.harvard.hul.ois.fits.junit.FitsBasicTest
@peshkira
Copy link

@carlwilson The problem lies within these two lines in the pom.xml

<sourceDirectory>src</sourceDirectory>
<testSourceDirectory>tests</testSourceDirectory>

It is not a good idea to overwrite mavens src and test dirs. I am not sure why @calvinwo has done it. Maybe there is a specific reason for this. Once you remove these lines, the build works again as expected.

Nonetheless, the problem that I see with this branch is that the whole maven repository is still local. It is great that calvinwo has converted the needed libraries to maven branches. Maybe we can push the ones that are not in any public maven repository to a OPF maven repo (I guess there is one) and use the rest from the official mavenrepo.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants