From 996ab5f9fa0155f593aa1d69687e42e09e5fe0ea Mon Sep 17 00:00:00 2001
From: Emilio Cota <ecg@google.com>
Date: Fri, 24 Jan 2025 16:27:55 -0800
Subject: [PATCH] [xla:cpu] rename LowerTrivialPass to LowerToLLVMPass

Trivial or not, LowerToLLVM is more descriptive.

PiperOrigin-RevId: 719470301
---
 xla/backends/cpu/codegen/emitters/transforms/BUILD     |  2 +-
 .../transforms/{lower_trivial.cc => lower_to_llvm.cc}  | 10 +++++-----
 xla/backends/cpu/codegen/emitters/transforms/passes.h  |  2 +-
 xla/backends/cpu/codegen/emitters/transforms/passes.td | 10 +++++-----
 .../tests/{lower_trivial.mlir => lower_to_llvm.mlir}   |  2 +-
 5 files changed, 13 insertions(+), 13 deletions(-)
 rename xla/backends/cpu/codegen/emitters/transforms/{lower_trivial.cc => lower_to_llvm.cc} (87%)
 rename xla/backends/cpu/codegen/emitters/transforms/tests/{lower_trivial.mlir => lower_to_llvm.mlir} (97%)

diff --git a/xla/backends/cpu/codegen/emitters/transforms/BUILD b/xla/backends/cpu/codegen/emitters/transforms/BUILD
index 8976e6c7e9ee52..1dc0eeeb23a612 100644
--- a/xla/backends/cpu/codegen/emitters/transforms/BUILD
+++ b/xla/backends/cpu/codegen/emitters/transforms/BUILD
@@ -32,7 +32,7 @@ gentbl_cc_library(
 
 cc_library(
     name = "passes",
-    srcs = ["lower_trivial.cc"],
+    srcs = ["lower_to_llvm.cc"],
     hdrs = ["passes.h"],
     deps = [
         ":passes_inc_gen",
diff --git a/xla/backends/cpu/codegen/emitters/transforms/lower_trivial.cc b/xla/backends/cpu/codegen/emitters/transforms/lower_to_llvm.cc
similarity index 87%
rename from xla/backends/cpu/codegen/emitters/transforms/lower_trivial.cc
rename to xla/backends/cpu/codegen/emitters/transforms/lower_to_llvm.cc
index 4ca33f12421b9e..787f82d1d80827 100644
--- a/xla/backends/cpu/codegen/emitters/transforms/lower_trivial.cc
+++ b/xla/backends/cpu/codegen/emitters/transforms/lower_to_llvm.cc
@@ -30,12 +30,12 @@ limitations under the License.
 
 namespace xla::cpu {
 
-#define GEN_PASS_DECL_LOWERTRIVIALPASS
-#define GEN_PASS_DEF_LOWERTRIVIALPASS
+#define GEN_PASS_DECL_LOWERTOLLVMPASS
+#define GEN_PASS_DEF_LOWERTOLLVMPASS
 #include "xla/backends/cpu/codegen/emitters/transforms/passes.h.inc"
 
 namespace {
-class LowerTrivialPass : public impl::LowerTrivialPassBase<LowerTrivialPass> {
+class LowerToLLVMPass : public impl::LowerToLLVMPassBase<LowerToLLVMPass> {
   void runOnOperation() override {
     mlir::MLIRContext* mlir_context = &getContext();
     mlir::RewritePatternSet patterns(mlir_context);
@@ -51,8 +51,8 @@ class LowerTrivialPass : public impl::LowerTrivialPassBase<LowerTrivialPass> {
 };
 }  // namespace
 
-std::unique_ptr<mlir::Pass> CreateLowerTrivialPass() {
-  return std::make_unique<LowerTrivialPass>();
+std::unique_ptr<mlir::Pass> CreateLowerToLLVMPass() {
+  return std::make_unique<LowerToLLVMPass>();
 }
 
 }  // namespace xla::cpu
diff --git a/xla/backends/cpu/codegen/emitters/transforms/passes.h b/xla/backends/cpu/codegen/emitters/transforms/passes.h
index 5479a1b7f0bf56..09e29808fa43d9 100644
--- a/xla/backends/cpu/codegen/emitters/transforms/passes.h
+++ b/xla/backends/cpu/codegen/emitters/transforms/passes.h
@@ -25,7 +25,7 @@ namespace xla::cpu {
 #define GEN_PASS_DECL
 #include "xla/backends/cpu/codegen/emitters/transforms/passes.h.inc"
 
-std::unique_ptr<mlir::Pass> CreateLowerTrivialPass();
+std::unique_ptr<mlir::Pass> CreateLowerToLLVMPass();
 
 #define GEN_PASS_REGISTRATION
 #include "xla/backends/cpu/codegen/emitters/transforms/passes.h.inc"
diff --git a/xla/backends/cpu/codegen/emitters/transforms/passes.td b/xla/backends/cpu/codegen/emitters/transforms/passes.td
index f15b3e5abffded..67f315b5f13b26 100644
--- a/xla/backends/cpu/codegen/emitters/transforms/passes.td
+++ b/xla/backends/cpu/codegen/emitters/transforms/passes.td
@@ -15,11 +15,11 @@ limitations under the License.
 
 include "mlir/Pass/PassBase.td"
 
-def LowerTrivialPass : Pass<"xla-cpu-lower-trivial", "mlir::ModuleOp"> {
-  let summary = "Trivial one shot lowering from tensors + xla_cpu to LLVM";
+def LowerToLLVMPass : Pass<"xla-cpu-lower-to-llvm", "mlir::ModuleOp"> {
+  let summary = "Lowering from tensors + xla_cpu to LLVM";
 
   let description = [{
-      This is a trivial pass for lowering tensors and xla_cpu operations to LLVM
+      This is a pass for lowering tensors and xla_cpu operations to LLVM
       dialect and pointers.
   }];
 
@@ -30,5 +30,5 @@ def LowerTrivialPass : Pass<"xla-cpu-lower-trivial", "mlir::ModuleOp"> {
     "xla::cpu::XlaCpuDialect",
   ];
 
-  let constructor = "::xla::cpu::CreateLowerTrivialPass()";
-}
\ No newline at end of file
+  let constructor = "::xla::cpu::CreateLowerToLLVMPass()";
+}
diff --git a/xla/backends/cpu/codegen/emitters/transforms/tests/lower_trivial.mlir b/xla/backends/cpu/codegen/emitters/transforms/tests/lower_to_llvm.mlir
similarity index 97%
rename from xla/backends/cpu/codegen/emitters/transforms/tests/lower_trivial.mlir
rename to xla/backends/cpu/codegen/emitters/transforms/tests/lower_to_llvm.mlir
index 2bb2c59b675b12..349e574a013b80 100644
--- a/xla/backends/cpu/codegen/emitters/transforms/tests/lower_trivial.mlir
+++ b/xla/backends/cpu/codegen/emitters/transforms/tests/lower_to_llvm.mlir
@@ -1,4 +1,4 @@
-// RUN: emitters_opt %s --xla-cpu-lower-trivial -split-input-file | FileCheck %s
+// RUN: emitters_opt %s --xla-cpu-lower-to-llvm -split-input-file | FileCheck %s
 
 func.func @fn(%arg0: index, %arg1: tensor<2xi32>) -> tensor<2xi32> {
   return %arg1 : tensor<2xi32>