From 75a903498985499d2c721b67bf18c9eaaaabe021 Mon Sep 17 00:00:00 2001 From: praptisharma28 <123169861+praptisharma28@users.noreply.github.com> Date: Sat, 25 Nov 2023 21:56:43 +0530 Subject: [PATCH 1/2] [qa] Commit check now work on github actions #163 Closes #163 --- openwisp-qa-check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openwisp-qa-check b/openwisp-qa-check index c4388554..fb4650ce 100755 --- a/openwisp-qa-check +++ b/openwisp-qa-check @@ -149,7 +149,7 @@ runblack() { runcheckcommit() { if [ -z "$COMMIT_MESSAGE" ]; then COMMIT_MESSAGE=$(git log -1 --pretty=%B); fi - if [ "$TRAVIS" = true ] && [ "$TRAVIS_PULL_REQUEST" = false ]; then + if [ "$GITHUB_ACTIONS" = true ] && [ "$GITHUB_EVENT_NAME" = "pull_request" ]; then echo "SKIPPED: Commit message check skipped!" else checkcommit --message "$COMMIT_MESSAGE" && From cfdb34185a702cbadbfb1d857cb32ec49e3f8c00 Mon Sep 17 00:00:00 2001 From: praptisharma28 <123169861+praptisharma28@users.noreply.github.com> Date: Wed, 29 Nov 2023 14:23:27 +0530 Subject: [PATCH 2/2] [qa] Removed the lines #163 Closes #163 --- openwisp-qa-check | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/openwisp-qa-check b/openwisp-qa-check index fb4650ce..93fd3d8b 100755 --- a/openwisp-qa-check +++ b/openwisp-qa-check @@ -149,18 +149,14 @@ runblack() { runcheckcommit() { if [ -z "$COMMIT_MESSAGE" ]; then COMMIT_MESSAGE=$(git log -1 --pretty=%B); fi - if [ "$GITHUB_ACTIONS" = true ] && [ "$GITHUB_EVENT_NAME" = "pull_request" ]; then - echo "SKIPPED: Commit message check skipped!" - else - checkcommit --message "$COMMIT_MESSAGE" && - echo "SUCCESS: Commit message check successful!" || - { - echo -e "Checked commit message:\n\n" - echo -e "$COMMIT_MESSAGE\n\n" - echoerr "ERROR: Commit message check failed!" - FAILURE=1 - } - fi + + checkcommit --message "$COMMIT_MESSAGE" && + echo "SUCCESS: Commit message check successful!" || + { + echo -e "Checked commit message:\n\n$COMMIT_MESSAGE\n\n" + echoerr "ERROR: Commit message check failed!" + FAILURE=1 + } } runcheckpendingmigrations() {