Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Results don't show in Firefox 3.6 and earlier #2053

Open
caugner opened this issue Jan 2, 2025 · 3 comments · May be fixed by #2054
Open

Results don't show in Firefox 3.6 and earlier #2053

caugner opened this issue Jan 2, 2025 · 3 comments · May be fixed by #2054

Comments

@caugner
Copy link
Contributor

caugner commented Jan 2, 2025

Ran npm start on this PR's branch.

Firefox 3.6:

image

Firefox 4:

image
@caugner
Copy link
Contributor Author

caugner commented Jan 2, 2025

Error console in Firefox 3.6 suggests this has to do with the use of Object.keys():

image

See Firefox 4 error console:
image

@caugner
Copy link
Contributor Author

caugner commented Jan 2, 2025

Corresponding code location:
image

@caugner
Copy link
Contributor Author

caugner commented Jan 2, 2025

Looks like that Object.keys() usage was introduced in 9443ad0#diff-84dd6a83459413d5bb638cd885f20ef0dbebf2ebf10d0f35d1c9ca424b0ca06aL169.

It might help to convert the browser-extensions.json object to an array of objects.

@caugner caugner linked a pull request Jan 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace usages of Object.keys() caugner/mdn-bcd-collector
1 participant
@caugner