Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure base64 encoding works on other platforms #95

Closed
jakubkoci opened this issue Sep 4, 2020 · 1 comment
Closed

Make sure base64 encoding works on other platforms #95

jakubkoci opened this issue Sep 4, 2020 · 1 comment

Comments

@jakubkoci
Copy link
Contributor

Module SignatureDecoratorUtils is using base64url package which apparently doesn't work on React Native. There is an issue about that in package repo brianloveswords/base64url#50.

I looked into the code and the problem is probably dependency on Buffer which is a globally available object in Node.js. I see two solutions:

  1. Implement functionality on our own.
  2. Use a different npm package with support for the web and React Native platform.

In both cases, I would suggest introducing a class JsonEncoder which would hide implementation details and provide the same API across the framework independently on a particular package.

@TimoGlastra
Copy link
Contributor

This is fixed by #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants