New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logger] Do not enforce the file and enable/disable logging on the fly #2242

Open

JeffreyDevloo opened this issue Jan 15, 2019 · 1 comment

Labels

state_codecomplete type_enhancement

Contributor

JeffreyDevloo commented Jan 15, 2019

The Framework current logging sets up a filehandler for every logger instantiated. This is just plain wrong.
It enforces:

The file to be preset (which is created as root 99% of the times)
A new FileHandler (you cannot chose which file to use)
Not using the default logger inheritance as every logger is on the same level

We should migrate to a logger system where all entrance points configure the root logger and any other possible loggers themselves.

Contributor Author

JeffreyDevloo commented Feb 19, 2019

Fixed by #2251

JeffreyDevloo added state_codecomplete type_enhancement labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment