Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on look and feel #1

Open
leicray opened this issue Sep 4, 2019 · 8 comments
Open

Comments on look and feel #1

leicray opened this issue Sep 4, 2019 · 8 comments

Comments

@leicray
Copy link

leicray commented Sep 4, 2019

Looks good!

In no particular order:

The "blue bar" at the top of the page could be shortened a bit: too much empty space above the site Title.

The sub-title should probably be in white, rather than pale blue, to improve the readability.

There are four blank lines at the top of the HTML markup for the home page. Might that trip-up some browser of HTML validators?

We need to think about the information content of the meta tags and whether additional tags are needed.

On the home page, the list of "Powered By" items should be link that open in a new tab. All links to outside resources should open in a new tab. Some sites, including Wikipedia, use a neat little symbol to indicate links to outside sites.

I presume that the three "300 x 200" boxes will eventually display relevant images.

The FAQs item on the Information drop-down menu does not lead anywhere, but you probably know that.

The sub-menu launched from the External Links item in Information drop-down menu looks odd. It took me a moment or two before I realised that it is organised into sections each with headings. However, the headings are in a smaller type face (font?) than the individual items in the section. Perhaps make the headings larger and "color" the text and/or make them bold in the CSS.

Finally for now, the Genes to Transcripts tool worked yesterday. but is returning a "Server Error (500)" error message when a gene symbol is submitted.

Thanks,

Raymond

@TeriForey
Copy link
Collaborator

I've updated the test server @leicray with most of those suggestions - let me know what you think.

@leicray
Copy link
Author

leicray commented Sep 10, 2019

Thanks for making the changes.

I finally got around to creating an account to access batch and vcf2hgvs but I have not received the confirmatory email which is needed to complete registration. I have now waited something like 20 minutes and it has not gone into a junk folder as far as I can see. Is this feature still "work in progress"?

Is it possible to shrink the height of the page in some way? I have a 1920 x 1200 monitor and I cannot see the entire page from top to bottom without scrolling.

The sub-menu launched from the External Links item in Information drop-down menu still looks odd. Did you adjust the CSS for that?

I tend to agree with you that the "validator" image does not really convey what the program does, but I cannot immediately think of how to improve it.

@leicray
Copy link
Author

leicray commented Sep 10, 2019

I have just noticed that the images/diagrams are ENORMOUS. The Gene_To_Transcripts.png image is 2494 x 1659 pixels (that's bigger than my monitor) and has a bit depth of 24. The images really need to be down-sampled to 16 bit and to 300 x 200 pixels, rather than having the browser resize them on the fly.

@TeriForey
Copy link
Collaborator

At the moment the emails aren't sending - I've still got it in debug mode to catch any errors which also means no emails. At the moment the email confirmation isn't required - once you're logged in you should be able to access everything.

I haven't changed anything with the external links just yet - I'll get on that asap.

The only way we can affect the height is to make everything smaller - including the text sizes. At the moment it's set up to be completely responsive to page width, so even on a phone screen everything is still legible - it does this by having an unconstrained height. Personally I don't think it's a problem to scroll down the page, it's fairly normal on most webpages and indeed a lot of sites nowadays put everything in a single page that you scroll through. There are places we could tweak the amount of content though - such as the batch input - which would reduce the height.

Thanks for the image spot, I created a 600x400 artboard so assumed the png would be saved to those dimensions but clearly not.

@leicray
Copy link
Author

leicray commented Sep 25, 2019

I just spotted a neat display trick on this web page:

https://wellcomeopenresearch.org/gateways/tgmi/about-this-gateway

Once the page is loaded and you begin to scroll down, the header collapses neatly to a more compact version and it restores automatically when you scroll back up. Might there be any value in implementing something like this on the new VV web interface?

@Peter-J-Freeman
Copy link
Collaborator

Hi Raymond,

Are we happy with this issue now? Can it be closed?

@leicray
Copy link
Author

leicray commented Dec 2, 2019

I have tried to access the new site (249?) via SPECTRE for one last look, but I'm getting a Service Unavailable error message.

@leicray
Copy link
Author

leicray commented Dec 2, 2019

OK, just discovered that it's on 290.

I'll post my comments in the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants