Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dead links to PDF docs from ORI source #149

Open
vanderburgt opened this issue Nov 6, 2023 · 3 comments
Open

Dead links to PDF docs from ORI source #149

vanderburgt opened this issue Nov 6, 2023 · 3 comments
Assignees
@breyten
Labels
bug Something isn't working 🪲 critical Affects major functionality or major data

Comments

@vanderburgt
Copy link
Collaborator

vanderburgt commented Nov 6, 2023 •
edited
Loading

Describe the bug

Summary
Results from the ORI source link to PDF docs that are not available.

URL / Environment
https://bron.live

Steps to reproduce**

  1. Go to bron.live
  2. Replace 'Windmolens' with 'Marineterrein'
  3. Scroll down to result preview
  4. See latest result from March 2022
  5. Click on result and click on 'Ga naar bron' button (English: 'Open source')
  6. See message: 'No Results found'

Expected behavior

The relevant result is show and the PDF is available for download.

Screenshots

Screen.Recording.2023-11-06.at.13.23.091.mov

Additional information

Possibly related to #148
@vanderburgt vanderburgt added the bug Something isn't working label Nov 6, 2023
@vanderburgt vanderburgt moved this to New 💭 in Bron Roadmap 🚀✨ Nov 6, 2023
@vanderburgt vanderburgt moved this from New 💭 to Upcoming ⏳ in Bron Roadmap 🚀✨ Nov 6, 2023
@vanderburgt vanderburgt mentioned this issue Nov 6, 2023
Closed
@vanderburgt vanderburgt added the 🪲 critical Affects major functionality or major data label Nov 6, 2023
@breyten breyten moved this from Upcoming ⏳ to Development 🐝 in Bron Roadmap 🚀✨ Nov 6, 2023
breyten added a commit that referenced this issue Nov 8, 2023
@breyten
Add a way to include a document link in documents stored in ES. See #149
a7302b3
@breyten
Copy link
Member

breyten commented Nov 8, 2023

There was no way to store a document url separate from a link. This functionality has been added. Document urls will be fetched from January 200 (as well as for new documents) in order to prevent having to recrawl the enite obv database. Still needs a minor frontend change.

breyten added a commit that referenced this issue Nov 9, 2023
@breyten
Prefer the document url if it is available. See #149
a21b1b8
breyten added a commit that referenced this issue Nov 9, 2023
@breyten
Better solution. See #149
8fc9f82
breyten added a commit that referenced this issue Nov 9, 2023
@breyten
Whoops. See #149
16f4b42
@breyten
Copy link
Member

breyten commented Nov 9, 2023

Document urls are presented where available instead . Note that this will sometimes still result in file not found errors, since documents can apparently be deleted. Not sure why. This could be remedied by placing a small proxy in between to check the links

@breyten
Copy link
Member

breyten commented Nov 14, 2023

Older documents are being fetched right now ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@breyten breyten

Labels
bug Something isn't working 🪲 critical Affects major functionality or major data
Projects
Bron Roadmap 🚀✨
Status: Development 🐝
Milestone
No milestone
Development

No branches or pull requests
2 participants
@breyten @vanderburgt