Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sync Optimization] Use the syncStrategy to identify the IDs of the resources required for sync #1513

Closed
1 of 8 tasks
Tracked by #1514
dubdabasoduba opened this issue Aug 6, 2022 · 4 comments
Closed
1 of 8 tasks
Tracked by #1514
Labels
Blocked Item is blocked by another prerequisite Enhancement New feature or request Remote Sync All issues related to syncing data from or to the FHIR server Size - XS < 1 day

Comments

@dubdabasoduba
Copy link
Member

dubdabasoduba commented Aug 6, 2022

Is your feature request related to a problem? Please describe.

  • Sync Optimization
    • This issue is to guide FHIR Core on what IDs it should fetch during sync.
  • Discussion can be found here

Describe the solution you'd like

  • Using the syncStrategy settings added here to identify the IDs to during sync.
  • Fetch all the IDs for the configured syncStrategy. This will involve the following
    • Generate sync params based on the fetched Ids. These IDs become the value for the sync params.
    • Pass the sync params to all the patient data-related sync calls made by the app. Here is a sample param ?_tag=123&_tag=345

Acceptance Criteria

  • Match the correct resource ids to the correct syncStrategy.
  • Generate correctly defined params for the different FHIR endpoints
  • Add all the sync params to all the GET endpoints.

Depends on

@dubdabasoduba dubdabasoduba added Enhancement New feature or request Remote Sync All issues related to syncing data from or to the FHIR server Size - XS < 1 day labels Aug 6, 2022
@pld
Copy link
Member

pld commented Aug 8, 2022

Can you explain why the resource names are being prefixed by practitioner when they are stored or matched in the user preferences?

@dubdabasoduba
Copy link
Member Author

Can you explain why the resource names being prefixed by practitioner when they are stored or matched in the user preferences?

@pld These IDs are related to the practitioner. It's a way to easily identify the resources tried to the practitioner assignment functionality. They really don't have any tech implications. We can change the naming to something else.

@pld
Copy link
Member

pld commented Aug 9, 2022

I think I’m missing some context on what makes this practitioner specific, is that because the practitioner is usually the user of the device, so they’ll be the one making this setting?

@dubdabasoduba dubdabasoduba changed the title [Sync Optimization] Use the syncAttribute to identify the IDs of the resources required for sync [Sync Optimization] Use the syncStrategy to identify the IDs of the resources required for sync Aug 12, 2022
@f-odhiambo f-odhiambo removed this from the Sprint 17 (Aug 16th - Aug 29th) milestone Aug 22, 2022
@dubdabasoduba dubdabasoduba added the Blocked Item is blocked by another prerequisite label Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Item is blocked by another prerequisite Enhancement New feature or request Remote Sync All issues related to syncing data from or to the FHIR server Size - XS < 1 day
Projects
None yet
Development

No branches or pull requests

3 participants