Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make replicaset.spec.revisionHistoryLimit configurable #1460

Open
mateusoliveira43 opened this issue Jul 12, 2024 · 5 comments
Open

Make replicaset.spec.revisionHistoryLimit configurable #1460

mateusoliveira43 opened this issue Jul 12, 2024 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@mateusoliveira43
Copy link
Contributor

As documented, ReplicaSets can become left out in cluster

https://github.com/openshift/oadp-operator/blob/master/docs/install_olm.md#verify-install

This can reproduced when testing upgrades

NAME                                                          DESIRED   CURRENT   READY   AGE
replicaset.apps/openshift-adp-controller-manager-686685cc8f   1         1         1       4m33s
replicaset.apps/openshift-adp-controller-manager-77c584bf8b   0         0         0       6m33s
replicaset.apps/velero-5fdf7d65df                             1         1         1       118s
replicaset.apps/velero-6bf5469f9c                             0         0         0       5m40s
@kaovilai
Copy link
Member

These are by design by kube to be left over. You can set following if you don't like seeing "historical" replicasets.

Clean up Policy
You can set .spec.revisionHistoryLimit field in a Deployment to specify how many old ReplicaSets for this Deployment you want to retain. The rest will be garbage-collected in the background. By default, it is 10.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2024
@kaovilai kaovilai changed the title Clean up ReplicaSets Consider setting replicaset.spec.revisionHistoryLimit to 0 Oct 14, 2024
@kaovilai kaovilai changed the title Consider setting replicaset.spec.revisionHistoryLimit to 0 Make replicaset.spec.revisionHistoryLimit configurable Oct 14, 2024
@kaovilai
Copy link
Member

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 14, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2025
@kaovilai
Copy link
Member

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants