Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of the CustomResourceDefinition type #1712

Closed
fxierh opened this issue Dec 23, 2023 · 3 comments
Closed

Inclusion of the CustomResourceDefinition type #1712

fxierh opened this issue Dec 23, 2023 · 3 comments
Assignees

Comments

@fxierh
Copy link

fxierh commented Dec 23, 2023

Currently the CustomResourceDefinition type is not included in this repo.
Any chance to incorporate this one into kubeSchemeBuilder ?

@fxierh fxierh removed their assignment Dec 23, 2023
@fxierh
Copy link
Author

fxierh commented Dec 23, 2023

/assign @JoelSpeed

@JoelSpeed
Copy link
Contributor

I believe the list is supposed to mirror https://github.com/kubernetes/client-go/blob/5a0a4247921dd9e72d158aaa6c1ee124aba1da80/kubernetes/scheme/register.go#L83-L135, which does not include the CRD types. They can easily be added to the scheme separately if required though. I expect we don't add it to the scheme by default since most operators do not need access to the CRD types within their scheme.

Personally, I tend to build up my own scheme in operators based on the types I know that I need, this reduces the memory footprint of the scheme.

@fxierh
Copy link
Author

fxierh commented Jan 3, 2024

@JoelSpeed I see. Thanks for you response.

@fxierh fxierh closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants