Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose metrics securely #1019

Open
ffromani opened this issue Sep 24, 2024 · 0 comments
Open

expose metrics securely #1019

ffromani opened this issue Sep 24, 2024 · 0 comments

Comments

@ffromani
Copy link
Member

Consolidating sparse musings about the topic in one place:the preferr

We want to re-enable the exporting of prometheus metrics securely. This affects both the operator proper and RTE.

  • controller-runtime gained a super nice feature to do this automatically. We can't consume it till the oldest kube version we support is 1.28.
  • we would STRONGLY prefer a consistent solution all across the supported versions (e.g. no controller-runtime against head and another solution for older branches)
  • the preferred approach is thus injecting a sidecar container with kube-rbac-proxy
  • the proxy image path should be overridable somehow if possible.
  • for RTE, the operator should learn introspecting its own manifest the image spec of the proxy and use the same image for RTE sidecars. This image should NOT be user-overridable
  • for the sidecar manifests and related, we can create a pkg/metrics package possibly with pkg/metrics/manifests/yaml or somthing like that
  • enabling full prometheus support in CI is not necessary for this effort
  • e2e testing is however a must; a simple curl against the proxy can be sufficient
  • we may want to create a custom kube-rbac-proxy imager ONLY FOR CI TESTING if this makes our life easier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant