From 08e69554d2f70756456a78435a931d97d9a76c64 Mon Sep 17 00:00:00 2001
From: Brandon Palm <bpalm@redhat.com>
Date: Tue, 21 Jan 2025 12:45:31 -0600
Subject: [PATCH] hive clusterimageset: return consistency (#878)

---
 pkg/hive/clusterimageset.go | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/pkg/hive/clusterimageset.go b/pkg/hive/clusterimageset.go
index ee10448e9..1a110debf 100644
--- a/pkg/hive/clusterimageset.go
+++ b/pkg/hive/clusterimageset.go
@@ -246,9 +246,7 @@ func (builder *ClusterImageSetBuilder) WithReleaseImage(image string) *ClusterIm
 		glog.V(100).Infof("The clusterimageset releaseImage is empty")
 
 		builder.errorMsg = "cannot set releaseImage to empty string"
-	}
 
-	if builder.errorMsg != "" {
 		return builder
 	}
 
@@ -297,13 +295,13 @@ func (builder *ClusterImageSetBuilder) validate() (bool, error) {
 	if builder.Definition == nil {
 		glog.V(100).Infof("The %s is undefined", resourceCRD)
 
-		builder.errorMsg = msg.UndefinedCrdObjectErrString(resourceCRD)
+		return false, fmt.Errorf(msg.UndefinedCrdObjectErrString(resourceCRD))
 	}
 
 	if builder.apiClient == nil {
 		glog.V(100).Infof("The %s builder apiclient is nil", resourceCRD)
 
-		builder.errorMsg = fmt.Sprintf("%s builder cannot have nil apiClient", resourceCRD)
+		return false, fmt.Errorf("%s builder cannot have nil apiClient", resourceCRD)
 	}
 
 	if builder.errorMsg != "" {