[BUG] Sanity tests do not connect to the cluster with username + password

[peternied]

What is the bug?
When the plugin install tests run they use src/test/java/org/opensearch/security/sanity/tests/SingleClusterSanityIT.java to make sure the cluster is operational. However, the user the admin cert - not the username and password. This prevented detecting that the username and password logic was not correctly configured

How can one reproduce the bug?

1. Manually execute the steps from the workflow file .github/workflows/plugin_install.yml
2. Notable at the end there is a step:

./gradlew integTestRemote -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername="opensearch" -Dhttps=true -Duser=admin -Dpassword=${{ env.CLUSTER_ADMIN_PASSWORD }} -i

3. Change the password to any value, execute the tests, they still pass

What is the expected behavior?
The tests should fail if the password is not valid

Do you have any additional context?

• Discovered while working on Demo configuration script requires admin password #3329

[cwperks]

@peternied I believe this issue can be closed. The tests fail when I supply a wrong password. This test in particular, checks to ensure that the password configured is correct.

These sanity tests extend OpenSearchRestTestCase which configures 2 separate rest clients:

1. client
2. adminClient

The adminClient is configured to send REST requests with the admin certificate, but this client is not used for the sanity tests.

[cwperks]

Closing this issue as it has already been resolved. See comment above.