[BUG] Debian and rpm Upgrade functionality is broken

[sruti1312]

What is the bug?
Upgrading performance analyzer to a higher version is broken from opendistro 1.10.1.

1. Fix the incorrect binary path in the systemd service.
2. After manually changing the binary path, it throws error

performance-analyzer-agent-cli[2042984]: Caused by: java.lang.ClassNotFoundException: com.amazon.opendistro.elasticsearch.performanceanalyzer.PerformanceAnalyzerApp

3. Need to revisit the postrm as it basically removes everything.
   Related issue: systemd service opendistro-performance-analyzer.service has the wrong binary path configured opendistro-for-elasticsearch/performance-analyzer#235

How can one reproduce the bug?
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

What is the expected behavior?
A clear and concise description of what you expected to happen.

What is your host/environment?

• OS: [e.g. iOS]
• Version [e.g. 22]
• Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.

[kkhatua]

This will need a revisit to see if the issue still exists after the fork off, as the problem refers to ODFE artifacts (precursor to Opensearch Plugins). Will mark it as Medium priority as we validate functionality through docker images for now..

[prudhvigodithi]

Hey I'm still getting this error when tested with 3.0.0-SNAPSHOT
Steps to re produce:

1. wget https://artifacts.opensearch.org/snapshots/core/opensearch/3.0.0-SNAPSHOT/opensearch-min-3.0.0-SNAPSHOT-linux-x64-latest.tar.gz
2. ./bin/opensearch to start the cluster
3. Install the PA plugin
   /bin/opensearch-plugin install https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/plugin/performance-analyzer/3.0.0.0-SNAPSHOT/performance-analyzer-3.0.0.0-20221024.210218-1.zip
4. Start the PA agent
   OPENSEARCH_HOME=/home/ec2-user/opensearch-3.0.0-SNAPSHOT OPENSEARCH_PATH_CONF=/home/ec2-user/opensearch-3.0.0-SNAPSHOT/bin/ OPENSEARCH_JAVA_HOME=/home/ec2-user/opensearch-3.0.0-SNAPSHOT/jdk/ ./bin/opensearch-performance-analyzer/performance-analyzer-agent-cli

Error:

Error: Could not find or load main class org.opensearch.performanceanalyzer.PerformanceAnalyzerApp
Caused by: java.lang.ClassNotFoundException: org.opensearch.performanceanalyzer.PerformanceAnalyzerApp

@dreamer-89 @bbarani @peterzhuamazon

[sgup432]

@prudhvigodithi The issue here seems to be with the performance-analyzer-agent-cli. The classpath mentioned here is wrong which is why this is resulting into ClassNotFoundException.

Should have been OPENSEARCH_ADDITIONAL_CLASSPATH_DIRECTORIES=plugins/opensearch-performance-analyzer/performance-analyzer-rca/lib. I verified that it is working after this. Will make change and raise fix for this.

Seems like it might have stopped working when we made folder structure changes after OS 2.0+ version.