Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCI] Bump into-stream from 6.0.0 to 8.0.0 #450

Open
nhtruong opened this issue Mar 22, 2023 · 8 comments
Open

[CCI] Bump into-stream from 6.0.0 to 8.0.0 #450

nhtruong opened this issue Mar 22, 2023 · 8 comments
Assignees

Comments

@nhtruong
Copy link
Collaborator

Dependabot is having trouble upgrading into-stream to the next major version as it breaks things. This version bump will have to be handled manually.

@nhtruong nhtruong added good first issue Good for newcomers CCI College Contributor Initiative labels Mar 22, 2023
@timursaurus
Copy link
Collaborator

Can i take this?

@nhtruong
Copy link
Collaborator Author

nhtruong commented Mar 22, 2023

@timursaurus You're quick haha! Let's leave this up for a couple of days and see if other students want to pick this up. I see that you've already have quite a few PRs out already (Amazing Work btw!) and we want to encourage other students to participate too. If no one snatches this in 2 days, it's yours :D

@timursaurus
Copy link
Collaborator

timursaurus commented Mar 23, 2023

Here's how I would take this issue to get my head around it:

Screenshot 2023-03-23 at 12 31 52

Open the detail view of the Commits block and pressed on the compare view anchor link

@nhtruong nhtruong changed the title [CCI] Bump into-stream from 6.0.0 to 7.0.0 [CCI] Bump into-stream from 6.0.0 to 8.0.0 Oct 2, 2023
@tejeshreddy
Copy link
Contributor

@nhtruong can I take a look at this?

@nhtruong
Copy link
Collaborator Author

nhtruong commented Dec 1, 2023

@tejeshreddy of course

@tejeshreddy
Copy link
Contributor

tejeshreddy commented Dec 3, 2023

I was looking at ways I can bump up the into-streams to 8.0.0. According to what I understand, It would require converting the existing project into an ESM according to the release notes for version >= 7.0.0. And, I was wondering if there is a plan to take this effort up, as it could be quite significant.

@nhtruong
Copy link
Collaborator Author

nhtruong commented Dec 4, 2023

That looks like a much bigger lift than anticipated. We will rewrite/convert this to Typescript and it will satisfy that condition then.

@nhtruong nhtruong removed good first issue Good for newcomers CCI College Contributor Initiative labels Dec 4, 2023
@tejeshreddy
Copy link
Contributor

Sure @nhtruong, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants