Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Possible Flaky] Run ftrepo vis_builder test will fail even tho 2.4.0 enable vis by default #394

Closed
peterzhuamazon opened this issue Nov 12, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@peterzhuamazon
Copy link
Member

Hi,

Without stating vis_builder.enabled: true in the osd yml, sometimes we see vis_builder fail the second ftrepo test.

  Running:  core-opensearch-dashboards/opensearch-dashboards/apps/vis_builder/da           (2 of 57)
            shboard.spec.js

  Visualization Builder Dashboard Tests
    ✓ Should have valid visualizations (12857ms)
    1) Should be able to add a visualization

I dont have a full log yet but I do see this issue happens on x64 linux tar, possibly flaky test.

Using this:
opensearch-project/opensearch-build#2649 (comment)

Thanks.

@peterzhuamazon peterzhuamazon added bug Something isn't working untriaged v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 12, 2022
@ashwin-pc
Copy link
Member

@peterzhuamazon a test log or any other information here would be useful. I've pushed a fix right after the release to fix a flakey test but based on what i'm seeing here, its hard to tell what the flakey test is.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Nov 14, 2022

@peterzhuamazon a test log or any other information here would be useful. I've pushed a fix right after the release to fix a flakey test but based on what i'm seeing here, its hard to tell what the flakey test is.

Right now I specifically enabled that setting in config and i dont see any failure yet.
I only see the failure if I dont specify the setting, and it is not always happening.

I will see if I can get a test log next time. Thanks.

@tianleh tianleh removed the untriaged label Nov 30, 2022
@seraphjiang seraphjiang added v2.5.0 'Issues and PRs related to version v2.5.0' and removed v2.4.0 'Issues and PRs related to version v2.4.0' labels Jan 5, 2023
@CCongWang
Copy link
Collaborator

Hi @peterzhuamazon , do you still see the flakiness? Do we still need to work on this issue?

@CCongWang
Copy link
Collaborator

removing v2.5.0 label for now, feel free to add proper labels

@CCongWang CCongWang removed the v2.5.0 'Issues and PRs related to version v2.5.0' label Mar 9, 2023
@xluo-aws
Copy link
Member

@peterzhuamazon Hi, Peter, is this still a problem in main?

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Jan 29, 2024

Hi @xluo-aws

I am not sure about main, but I personally havent seen this for a while in 2.x.

Probably because I specifically enable it here already: https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.12.0/opensearch-dashboards-2.12.0-test.yml#L14

Anyway, I do not think this is a blocker.

Will close issue.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants