Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration Tests and CI Actions to Prevent Bugs [FEATURE] #71

Open
IanHoang opened this issue Mar 24, 2023 · 1 comment
Open

Add Integration Tests and CI Actions to Prevent Bugs [FEATURE] #71

IanHoang opened this issue Mar 24, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@IanHoang
Copy link
Collaborator

Is your feature request related to a problem?

There are no CI tests being run on PRs. It'd be nice to have a way for us to quickly run "integration tests" to changes made to workloads does not introduce errors. This has happened a few times already when users updated so and nyc_taxis, which affected other users using OSB (see example issue here). This would reduce the turn-around-time required for maintainers to dive into the code base to understand where the bug was introduced.

What solution would you like?

Utilize Github Actions to run the following:

  • Run a "lint" on formatting of all official workload's files
  • Run an OSB command with --test-mode appended for the official workload that's having the proposed change

What alternatives have you considered?

  • Using docker image but the issue there is that it would be using the changes already incorporated in official OSB workloads. However, we could get around this by pointing it to the user forked workload repository in benchmark.ini
[workloads]
default.url = https://github.com/opensearch-project/opensearch-benchmark-workloads

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@IanHoang IanHoang added enhancement New feature or request untriaged and removed untriaged labels Mar 24, 2023
@IanHoang
Copy link
Collaborator Author

Merging this issue with this one: #40

@IanHoang IanHoang added the good first issue Good for newcomers label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant