We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple RestActions catch the FlowFrameworkException but then ignore its status using ExceptionsHelper:
ExceptionsHelper
FlowFrameworkException ex = new FlowFrameworkException(exception.getMessage(), ExceptionsHelper.status(exception)); XContentBuilder exceptionBuilder = ex.toXContent(channel.newErrorBuilder(), ToXContent.EMPTY_PARAMS); channel.sendResponse(new BytesRestResponse(ex.getRestStatus(), exceptionBuilder));
The RestStatus from the FlowFrameworkException is returned.
I've addressed this in PR #271 by changing the first line above to:
FlowFrameworkException ex = exception instanceof FlowFrameworkException ? (FlowFrameworkException) exception : new FlowFrameworkException(exception.getMessage(), ExceptionsHelper.status(exception));
That needs to be copied over to all the other REST handlers.
Suggest this bug is addressed at the same time as #292 and #274
The text was updated successfully, but these errors were encountered:
dbwiddis
Successfully merging a pull request may close this issue.
What is the bug?
Multiple RestActions catch the FlowFrameworkException but then ignore its status using
ExceptionsHelper
:How can one reproduce the bug?
What is the expected behavior?
The RestStatus from the FlowFrameworkException is returned.
Do you have any additional context?
I've addressed this in PR #271 by changing the first line above to:
That needs to be copied over to all the other REST handlers.
Suggest this bug is addressed at the same time as #292 and #274
The text was updated successfully, but these errors were encountered: