Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Bedrock Rerank API #9027 #9029

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

tkykenmt
Copy link
Contributor

@tkykenmt tkykenmt commented Jan 7, 2025

Description

Amazon Bedrock introduced Rerank model support. Since 2.19, OpenSearch will be able to invoke Rerank models on Amazon Bedrock with no implementation on custom pre and post functions using pre-built functions. I've created original issue [1] and PR [2].

[1] opensearch-project/ml-commons#3254
[2] opensearch-project/ml-commons#3339

Issues Resolved

Closes #9027

Version

2.19-

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

github-actions bot commented Jan 7, 2025

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@kolchfa-aws kolchfa-aws added release-notes PR: Include this PR in the automated release notes v2.19.0 labels Jan 8, 2025
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws @tkykenmt Please see my changes and let me know if you have any questions. Thanks!

_ml-commons-plugin/tutorials/reranking-bedrock.md Outdated Show resolved Hide resolved
_ml-commons-plugin/tutorials/reranking-bedrock.md Outdated Show resolved Hide resolved
_ml-commons-plugin/tutorials/reranking-bedrock.md Outdated Show resolved Hide resolved
_ml-commons-plugin/tutorials/reranking-bedrock.md Outdated Show resolved Hide resolved
_ml-commons-plugin/tutorials/reranking-bedrock.md Outdated Show resolved Hide resolved
_ml-commons-plugin/tutorials/reranking-bedrock.md Outdated Show resolved Hide resolved
_ml-commons-plugin/tutorials/reranking-bedrock.md Outdated Show resolved Hide resolved
_ml-commons-plugin/tutorials/reranking-bedrock.md Outdated Show resolved Hide resolved
_ml-commons-plugin/tutorials/reranking-bedrock.md Outdated Show resolved Hide resolved
_ml-commons-plugin/tutorials/reranking-bedrock.md Outdated Show resolved Hide resolved
@tkykenmt
Copy link
Contributor Author

tkykenmt commented Jan 9, 2025

@natebower
Thank you for prompt feedback. Looks good to me. I fixed wrong field name on Amazon Bedrock Rerank API output
on the commit 40a600f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes PR: Include this PR in the automated release notes v2.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add support for Bedrock Rerank API
3 participants