-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Linear and Logistic Regression Parameters & Improve Documentation #8982
base: main
Are you sure you want to change the base?
Update Linear and Logistic Regression Parameters & Improve Documentation #8982
Conversation
- Add comprehensive documentation for supported: - Optimizers (SIMPLE_SGD, LINEAR_DECAY_SGD, etc.) - Objective types (ABSOLUTE_LOSS, HUBER, SQUARED_LOSS) - Momentum types (STANDARD, NESTEROV) - Fix parameter name typos Signed-off-by: rithin-pullela-aws <[email protected]>
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Corresponding code/ parameter names: https://github.com/opensearch-project/ml-commons/tree/main/common/src/main/java/org/opensearch/ml/common/input/parameter/regression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @rithin-pullela-aws! Could we add some more information for the user about these options?
Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Rithin Pullela <[email protected]>
…momentum type. Signed-off-by: rithin-pullela-aws <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, @rithin-pullela-aws! LGTM
Description
Describe what this change achieves.
Issues Resolved
Closes #8981
Version
List the OpenSearch version to which this PR applies, e.g. 2.14, 2.12--2.14, or all.
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.