fix: disable top input when no access #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
wanglam
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
raintygao
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 93.26% 93.27% +0.01%
==========================================
Files 46 46
Lines 1218 1220 +2
Branches 291 292 +1
==========================================
+ Hits 1136 1138 +2
Misses 80 80
Partials 2 2 ☔ View full report in Codecov by Sentry. |
ruanyl
reviewed
Dec 27, 2023
| @@ -179,6 +182,7 @@ export const HeaderChatButton = (props: HeaderChatButtonProps) => { | |||
| )} | |||
| </span> | |||
| } | |||
| disabled={!props.userHasAccess} | |||
There was a problem hiding this comment.
Have you tested if the click handler on line 161 is also disabled?
There was a problem hiding this comment.
We only disable the chat input in this PR. Do we need to disable the dashboard assistant icon? I think the icon still can be clicked before the chat input added.
There was a problem hiding this comment.
Then user can still click the icon to display the flyout, that also makes sense to me.
raintygao
approved these changes
Dec 27, 2023
ruanyl
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disable top input when user no access
Before:
After:
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.