Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unhandled exception when workspace id not exists #458

Merged

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Feb 22, 2025

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test.
  • New functionality has user manual doc added.
  • Commits are signed per the DCO using --signoff.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ruanyl ruanyl force-pushed the fix-500-error-when-workspace-id-invalid branch from fa71052 to a38fe3e Compare February 25, 2025 04:27
@ruanyl ruanyl added the backport 2.x Trigger the backport flow to 2.x label Feb 25, 2025
@ruanyl ruanyl merged commit 23896ad into opensearch-project:main Feb 25, 2025
11 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-assistant/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-assistant/backport-2.x
# Create a new branch
git switch --create backport/backport-458-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 23896aded120dc88e49344118c47d444788e8f76
# Push it to GitHub
git push --set-upstream origin backport/backport-458-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-assistant/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-458-to-2.x.

@ruanyl ruanyl added backport 2.x Trigger the backport flow to 2.x and removed backport 2.x Trigger the backport flow to 2.x labels Feb 25, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 25, 2025
* fix unhandled exception when workspace id not exists

Signed-off-by: Yulong Ruan <[email protected]>

* update CHANGELOG

Signed-off-by: Yulong Ruan <[email protected]>

---------

Signed-off-by: Yulong Ruan <[email protected]>
(cherry picked from commit 23896ad)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Trigger the backport flow to 2.x failed backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants