[Backport 2.x] 500 error if workspace is invalid

package.json

@@ -45,4 +45,4 @@
     "micromatch": "^4.0.8",
     "cross-spawn": "^7.0.5"
   }
-}
+}

server/routes/error_handler.ts

@@ -17,8 +17,12 @@ export const handleError = (e: any, res: OpenSearchDashboardsResponseFactory, lo
   // handle http response error of calling backend API
   if (e.statusCode) {
     if (e.statusCode >= 400 && e.statusCode <= 499) {
+      let message = typeof e.body === 'string' ? e.body : JSON.stringify(e.body);
+      if (!message) {
+        message = e.message;
+      }
       return res.customError({
-        body: { message: typeof e.body === 'string' ? e.body : JSON.stringify(e.body) },
+        body: { message: message || 'unknow error' },
         statusCode: e.statusCode,
       });
     } else {

server/routes/summary_routes.ts

@@ -98,13 +98,14 @@ export function registerSummaryAssistantRoutes(
       },
     },
     router.handleLegacyErrors(async (context, req, res) => {
-      const client = await getOpenSearchClientTransport({
-        context,
-        dataSourceId: req.query.dataSourceId,
-      });
-      const assistantClient = assistantService.getScopedClient(req, context);
-
       try {
+        const client = await getOpenSearchClientTransport({
+          context,
+          dataSourceId: req.query.dataSourceId,
+        });
+
+        const assistantClient = assistantService.getScopedClient(req, context);
+
         const insightAgentId = await detectInsightAgentId(
           req.body.insightType,
           req.body.summaryType,