Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a new draft does not include the old search terms #2321

Open
tomodwyer opened this issue Jan 24, 2025 · 2 comments
Open

Creating a new draft does not include the old search terms #2321

tomodwyer opened this issue Jan 24, 2025 · 2 comments
Labels
bug Something isn't working initiatve:codelist-builder

Comments

@tomodwyer
Copy link
Member

Steps to replicate

  • Given an existing codelist, a user makes a new draft (1)
  • When the draft loads, it shows 54 unresolved codelists (2)
  • But the user cannot see the existing search terms used to create the codelist (3)
  • It is not clear if the unresolved codes are from previous searches which have been updated when the draft was created
    • Or if they have come from somewhere else

Screenshots


@lucyb lucyb added the bug Something isn't working label Jan 28, 2025
@lucyb
Copy link
Contributor

lucyb commented Feb 4, 2025

@Jongmassey can you have a look at what the expected behaviour should be, please.

@Jongmassey
Copy link
Contributor

This is the expected behaviour as far as the code, if not the user, is concerned.

AIUI creating a new version calls create_new_version_with_codes which builds a new hierarchy for the new version based on the codes in the previous version, but doesn't copy the related searches used to build that version.

There's some thinking to be done around the searches-results-[in|ex]clusions-codes path (esp wrt changes in the coding system over which the searches are run - AFAICT the new version will be related to the latest release) to see if it is possible/valid to base a new version on codes but also bring along searches, or whether using the searches as the basis for the new version is viable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working initiatve:codelist-builder
Projects
None yet
Development

No branches or pull requests

3 participants