-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RELEASE_HOST config for release-hatch deployment #40
Comments
Thanks for the write-up. What is the effect, on which kinds of end-users, of this misconfiguration? |
It means that the `view level 4 outputs' button on job-server, will not work for the backend, it will show empty filelist and a 403 |
stupid comment button |
This is still current, right? Is it important enough to get into Regatta? |
Probably not, it's a test framework fix, so would be good but probably not essential |
is this fixed by #49 ? |
RELEASE_HOST is wrongly set to
http://localhost:8001
for the test-backend, which means all requests from job-server fail to validate.Changing this to
https://test.opensafely.org
fixes the issue, however it breaks the functional test in release-hatch, as that was written to assume localhost. So release-hatch's functional test client needs to be able to a take a RELEASE_HOST argument, and then we can update the test here to use it.The text was updated successfully, but these errors were encountered: