Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RELEASE_HOST config for release-hatch deployment #40

Open
bloodearnest opened this issue Sep 20, 2021 · 6 comments
Open

Fix RELEASE_HOST config for release-hatch deployment #40

bloodearnest opened this issue Sep 20, 2021 · 6 comments

Comments

@bloodearnest
Copy link
Member

RELEASE_HOST is wrongly set to http://localhost:8001 for the test-backend, which means all requests from job-server fail to validate.

Changing this to https://test.opensafely.org fixes the issue, however it breaks the functional test in release-hatch, as that was written to assume localhost. So release-hatch's functional test client needs to be able to a take a RELEASE_HOST argument, and then we can update the test here to use it.

@sebbacon
Copy link

Thanks for the write-up. What is the effect, on which kinds of end-users, of this misconfiguration?

@bloodearnest
Copy link
Member Author

It means that the `view level 4 outputs' button on job-server, will not work for the backend, it will show empty filelist and a 403

@bloodearnest
Copy link
Member Author

stupid comment button

@sebbacon
Copy link

sebbacon commented Nov 8, 2021

This is still current, right? Is it important enough to get into Regatta?

@bloodearnest
Copy link
Member Author

Probably not, it's a test framework fix, so would be good but probably not essential

@madwort
Copy link
Contributor

madwort commented Aug 11, 2023

is this fixed by #49 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants