Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new version breaks Win64 compilation with MinGW64 #111

Closed
agentzh opened this issue Oct 8, 2020 · 0 comments · Fixed by #112
Closed

The new version breaks Win64 compilation with MinGW64 #111

agentzh opened this issue Oct 8, 2020 · 0 comments · Fixed by #112
Assignees

Comments

@agentzh
Copy link
Member

agentzh commented Oct 8, 2020

The newly ported string hashing implementation breaks the build on 64-bit Windows using MinGW64:

C:\msys64\home\agentzh\work\openresty-1.19.3.1rc0\build\LuaJIT-2.1-20201002\src/x64/src/lj_str_hash_x64.h:158: undefined reference to `srandom'
C:\msys64\home\agentzh\work\openresty-1.19.3.1rc0\build\LuaJIT-2.1-20201002\src/x64/src/lj_str_hash_x64.h:167: undefined reference to `random'
C:\msys64\home\agentzh\work\openresty-1.19.3.1rc0\build\LuaJIT-2.1-20201002\src/x64/src/lj_str_hash_x64.h:168: undefined reference to `random'
C:\msys64\home\agentzh\work\openresty-1.19.3.1rc0\build\LuaJIT-2.1-20201002\src/x64/src/lj_str_hash_x64.h:179: undefined reference to `random'
C:\msys64\home\agentzh\work\openresty-1.19.3.1rc0\build\LuaJIT-2.1-20201002\src/x64/src/lj_str_hash_x64.h:179: undefined reference to `random'
collect2.exe: error: ld returned 1 exit status

@siddhesh Will you have a quick look at it? Thanks!

siddhesh added a commit that referenced this issue Oct 10, 2020
This reverts the reversion that was done to merge with LuaJIT/LuaJIT.

Fixes #111.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants