Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataDA does not allow zero follow-up time #850

Closed
Puzzled-Face opened this issue Aug 1, 2024 · 1 comment · Fixed by #851
Closed

DataDA does not allow zero follow-up time #850

Puzzled-Face opened this issue Aug 1, 2024 · 1 comment · Fixed by #851
Assignees
Labels
blocked bug Something isn't working CRAN good first issue Good for newcomers invalid This doesn't seem right

Comments

@Puzzled-Face
Copy link
Collaborator

Puzzled-Face commented Aug 1, 2024

If a DADesign's model is updated on the same day as a participant enrols (so that this participant's follow-up time is zero), the following error is reported:

Error in `validObject()`:
! invalid class "DataDA" object: u must be of type double, nObs length, non-negative and not greater than Tmax

u is a vector of DLT-free survival times.

This seems unnecessarily strict: two participants might well enrol on the same day. Or what if a participant immediately reports a DLT? Is there a technical reason why survival must be strictly positive? If not, I feel the us should simply be non-negative rather than strictly positive.

The error message is also inconsistent with the code, the relevant part of which is:

  v$check(
    test_numeric(object@u, upper = object@Tmax, len = object@nObs, any.missing = FALSE) &&
      all(object@u > 0),
    "u must be of type double, nObs length, non-negative and not greater than Tmax"
  )

#815 may be related.

@Puzzled-Face Puzzled-Face added bug Something isn't working good first issue Good for newcomers invalid This doesn't seem right CRAN labels Aug 1, 2024
@Puzzled-Face Puzzled-Face self-assigned this Aug 2, 2024
@Puzzled-Face Puzzled-Face linked a pull request Aug 2, 2024 that will close this issue
@Puzzled-Face
Copy link
Collaborator Author

Blocked by #852.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working CRAN good first issue Good for newcomers invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant