You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But with the indirect edges appearing at the bottom of the diagram for each of these two examples, clicking on that edge makes the pop-up window appear in the middle of the diagram rather than over the middle of the edge in question.
To Reproduce
Steps to reproduce the behavior:
Paste this JSON into the visualiser tool and click 'Draw'
Click on the owns 60% indirect edge going from Person 1 to Company B
The statement property pop-up window should appear but is centred in the middle of the whole diagram not in the middle of the edge in question (see image below)
Expected behavior
The statement property pop-up window should appear centred on the middle of the edge the user has clicked rather than the middle of the whole diagram
Screenshots
Desktop (please complete the following information):
OS: iOS
Browser: Chrome
Version: 130.0.6723.117 (Official Build) (arm64)
The text was updated successfully, but these errors were encountered:
The reason this happens is that it uses the bounding box of the edge clicked, so in this example it uses the upper-most edge (i.e. where the edge curves upwards) as the top of the edge and places the tooltip there:
To fix this will likely involve storing the mouse (or touch) position at the point of interaction and setting the tooltip's coordinates to that.
Describe the bug
When testing example data including https://github.com/openownership/data-standard/blob/main/examples/mixed-direct-and-indirect-ownership.json and https://github.com/openownership/data-standard/blob/main/examples/multiple-indirect-ownership.json, the statement property pop-ups for most of the nodes and edges appear centred on the node/edge which the user has clicked on.
But with the indirect edges appearing at the bottom of the diagram for each of these two examples, clicking on that edge makes the pop-up window appear in the middle of the diagram rather than over the middle of the edge in question.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The statement property pop-up window should appear centred on the middle of the edge the user has clicked rather than the middle of the whole diagram
Screenshots
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: