Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest BODS 0.4 data #97

Open
3 of 6 tasks
kd-ods opened this issue Jun 7, 2024 · 3 comments
Open
3 of 6 tasks

Ingest BODS 0.4 data #97

kd-ods opened this issue Jun 7, 2024 · 3 comments
Assignees

Comments

@kd-ods
Copy link
Collaborator

kd-ods commented Jun 7, 2024

  • Upgrade requirements (match versions in data-standard, solve any issues)
  • modify compile-to-json-schema to handle urns etc.
  • data: add schema-0-4-0.json
  • Update DataReader (count_statement_types etc.)
  • Update SchemaBODS (default version, types methods)
  • Update JSONSchemaValidator (switch Draft4/2020-12 base on schema version)
@kd-ods
Copy link
Collaborator Author

kd-ods commented Jun 7, 2024

The BODS 0.4 datasets in the Examples directory may be useful for this. They won't throw any schema validation errors.

@kd-ods
Copy link
Collaborator Author

kd-ods commented Jul 30, 2024

From Ed: Given that references in schema are now using urns, the first thing is to update compile-to-json-schema to handle urns, so that I can build the schema-0-4-0.json file.

@radix0000 radix0000 moved this from Ready to In Progress in Data Review Tool update (for BODS 0.4) Jul 31, 2024
@radix0000
Copy link
Collaborator

radix0000 commented Jul 31, 2024

The schema-0-4-0.json file has been generated, but has involved hacking both compile-to-json-schema and jsonref (which we don't control). Will need to address this in some way at end of project, once we are sure result is correct.

See: https://github.com/orgs/openownership/projects/10?pane=issue&itemId=72842291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants