-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace test data with fictitious examples #42
Comments
This was copied across from Open Data Services' (internal) issue http://bods.opendataservices.coop/redmine/issues/563 |
Can we be clear what data needs to be removed? Thanks. Noting that a standard pull request will mean that the data will still be available in the usual git history. We can rewrite history to remove the data fully, but that will take much more time and cause issues for anyone else with checked out versions. |
Discussing this, it's just Chris Taggarts details, so we can just remove it now and not worry about the git rewrite. |
This test data file is also a real company/person: https://github.com/openownership/data-standard/blob/master/tests/data/bods-package/valid/valid-bods-package-linking-annotations.json |
This will be removed for BODS 0.4 tests and beyond. |
The current test data in https://github.com/openownership/lib-cove-bods/tree/master/tests/fixtures has examples of actual companies. In line with our other CoVE instances and the BODS standard website we should replace this test data with fictitious people and companies.
The text was updated successfully, but these errors were encountered: