Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format validation for invalid files #63

Open
odscrachel opened this issue Apr 10, 2024 · 2 comments
Open

format validation for invalid files #63

odscrachel opened this issue Apr 10, 2024 · 2 comments
Assignees

Comments

@odscrachel
Copy link
Collaborator

In the list of validation keywords format isn't an option. I couldn't get an invalid test to work with an incorrect uri without using format in the expected_errors.csv. I can see though that format isn't listed in https://json-schema.org/draft/2020-12/meta/validation so I'm not sure if this is correct or what keyword to use instead?

@kathryn-ods
Copy link
Contributor

I think format is the correct one to use here

@kd-ods
Copy link
Collaborator

kd-ods commented Apr 16, 2024

It looks like format validation is a special case in json schema, and doesn't work by default. But I think @rhiaro has set things up so that we can enforce format constraints.

Assigning to @rhiario to confirm that we're correctly using the 'format' keyword in the list of expected errors, and that we should edit the handbook to add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants