Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Next.js canary causes patch of '_nextBubbleNoFallback' to fail #221

Closed
hach-que opened this issue Jan 3, 2025 · 1 comment · Fixed by #232
Closed

[BUG] Next.js canary causes patch of '_nextBubbleNoFallback' to fail #221

hach-que opened this issue Jan 3, 2025 · 1 comment · Fixed by #232
Labels
bug Something isn't working triage

Comments

@hach-que
Copy link

hach-que commented Jan 3, 2025

Describe the bug

When using Next.js canary, patching fails:

 - patching exception bubbling
file:///mnt/c/Work/website/node_modules/@opennextjs/cloudflare/dist/cli/build/bundle-server.js:183
            throw new Error(`Failed to patch ${target}`);
                  ^

Error: Failed to patch exception bubbling
    at patchCodeWithValidations (file:///mnt/c/Work/website/node_modules/@opennextjs/cloudflare/dist/cli/build/bundle-server.js:183:19)
    at async updateWorkerBundledCode (file:///mnt/c/Work/website/node_modules/@opennextjs/cloudflare/dist/cli/build/bundle-server.js:122:25)
    at async bundleServer (file:///mnt/c/Work/website/node_modules/@opennextjs/cloudflare/dist/cli/build/bundle-server.js:104:5)
    at async build (file:///mnt/c/Work/website/node_modules/@opennextjs/cloudflare/dist/cli/build/index.js:75:5)
    at async file:///mnt/c/Work/website/node_modules/@opennextjs/cloudflare/dist/cli/index.js:7:1

This is presumably due to this commit here: vercel/next.js@2e46a18

Steps to reproduce

  1. Set up a Next.js project using canary version, and set up to deploy to CloudFlare.
  2. Observe patching failure.

Expected behavior

Patching should succeed.

@opennextjs/cloudflare version

0.3.3

Wrangler version

3.99.0

next info output

Node.js v22.12.0

Operating System:
  Platform: linux
  Arch: x64
  Version: #1 SMP Tue Nov 5 00:21:55 UTC 2024
  Available memory (MB): 15946
  Available CPU cores: 24
Binaries:
  Node: 22.12.0
  npm: 10.9.0
  Yarn: 4.6.0
  pnpm: N/A
Relevant Packages:
  next: 15.1.1-canary.24
  eslint-config-next: N/A
  react: 19.0.0
  react-dom: 19.0.0
  typescript: 5.7.2
Next.js Config:
  output: N/A

Additional context

No response

@dario-piotrowicz
Copy link
Contributor

Thanks a bunch for the issue @hach-que 🙂

I've opened #232 to fix the bug, but as I mentioned in the PR fixing this doesn't yet make the application work with the canary release 😢, I'm also looking in the other issues that we have with the canary release separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants