Check Validation for different identifier namespaces

[darupp]

We have lots of identifier namespaces such as issn, isbn, doi etc. I'm not sure whether they are validated or not. You can enter a regex in the namespace definition - is there a validation function active and where they get checked? If so, we should write regexes for the namespaces.

[hornmo]

There is a rudimentary regex validation in Identifier, but it is currently only working with a static list for a small selection of identifiers.

gokb/server/gokbg3/grails-app/domain/org/gokb/cred/Identifier.groovy

Lines 19 to 44 in 80d5690

	private static nameSpaceRules = [
	"issn" : "^\\d{4}\\-\\d{3}[\\dX]\$",
	"issnl" : "^\\d{4}\\-\\d{3}[\\dX]\$",
	"eissn" : "^\\d{4}\\-\\d{3}[\\dX]\$",
	"zdb" : "^\\d+\\-[\\dxX]\$"
	]
	static constraints = {
	namespace (nullable:false, blank:false)
	value (validator: { val, obj ->
	if (!val || val.trim().size() == 0) {
	return ['notNull']
	}
	def norm_id = Identifier.normalizeIdentifier(val)
	def dupes = Identifier.findByNamespaceAndNormname(obj.namespace, norm_id)
	if (dupes && dupes != obj) {
	return ['notUnique']
	}
	if (nameSpaceRules[obj.namespace.value] && !(val ==~ nameSpaceRules[obj.namespace.value])) {
	return ['illegalIdForm.' + obj.namespace.value ]
	}
	})
	}

A better approach would be to use the pattern field from IdentifierNamespace, although this would also not encompass verifying check digits etc., not to mention ISBNs (hyphenation, 13vs10).