From e90d202bec52617b6417fa7424e3c63a05191a93 Mon Sep 17 00:00:00 2001
From: Rodrigo Arze Leon <rodrigo.arze@Rodrigos-Mac-mini.local>
Date: Wed, 30 Oct 2024 17:13:10 -0400
Subject: [PATCH] Remove max height in form and update styles so content
 adjusts better to container/iframe

---
 .../hocs/WithConnectorConnect.tsx             | 48 ++++++++++---------
 packages/ui/components/SchemaForm.tsx         |  2 +-
 2 files changed, 27 insertions(+), 23 deletions(-)

diff --git a/packages/engine-frontend/hocs/WithConnectorConnect.tsx b/packages/engine-frontend/hocs/WithConnectorConnect.tsx
index 3f980d7f..d2d94631 100644
--- a/packages/engine-frontend/hocs/WithConnectorConnect.tsx
+++ b/packages/engine-frontend/hocs/WithConnectorConnect.tsx
@@ -150,7 +150,7 @@ export const WithConnectorConnect = ({
         if (err === CANCELLATION_TOKEN) {
           return
         }
-        console.log(ccfg.connector.displayName + ' connection error:',err)
+        console.log(ccfg.connector.displayName + ' connection error:', err)
         toast({
           title: `Failed to connect to ${ccfg.connector.displayName}`,
           // description: `${err}`,
@@ -196,8 +196,12 @@ export const WithConnectorConnect = ({
         label: resource ? 'Reconnect' : 'Connect',
       })}
 
-      <DialogContent className="max-h-[600px] overflow-visible">
-        <DialogHeader>
+      <DialogContent
+        className="flex flex-col overflow-visible"
+        style={{
+          maxHeight: 'min(90vh, 700px)',
+        }}>
+        <DialogHeader className="flex-shrink-0">
           <DialogTitle>
             <div className="flex items-center">
               <span className="mr-2">
@@ -205,8 +209,8 @@ export const WithConnectorConnect = ({
               </span>
               {ccfg.connector.name === 'greenhouse' && (
                 <div className="relative inline-block">
-                  <InfoIcon className="h-5 w-5 cursor-help text-gray-500 peer" />
-                  <div className="absolute bottom-full left-1/2 mb-2 w-64 -translate-x-1/2 rounded-md bg-[#272731] p-2 text-sm text-white opacity-0 transition-opacity peer-hover:opacity-100 pointer-events-none">
+                  <InfoIcon className="peer h-5 w-5 cursor-help text-gray-500" />
+                  <div className="pointer-events-none absolute bottom-full left-1/2 mb-2 w-64 -translate-x-1/2 rounded-md bg-[#272731] p-2 text-sm text-white opacity-0 transition-opacity peer-hover:opacity-100">
                     <p className="italic">
                       Generate a custom API key with{' '}
                       <a
@@ -229,23 +233,23 @@ export const WithConnectorConnect = ({
             </DialogDescription>
           )}
         </DialogHeader>
-        <SchemaForm
-          ref={formRef}
-          schema={z.object({})}
-          jsonSchemaTransform={(schema) =>
-            ccfg.connector.schemas.resourceSettings ?? schema
-          }
-          formData={{}}
-          // formData should be non-null at this point, we should fix the typing
-          loading={connect.isLoading}
-          onSubmit={({formData}) => {
-            console.log('resource form submitted', formData)
-            connect.mutate({connectorConfigId: ccfg.id, settings: formData})
-          }}
-          hideSubmitButton
-        />
-        {/* Children here */}
-        <DialogFooter>
+        <div className="overflow-y-auto">
+          <SchemaForm
+            ref={formRef}
+            schema={z.object({})}
+            jsonSchemaTransform={(schema) =>
+              ccfg.connector.schemas.resourceSettings ?? schema
+            }
+            formData={{}}
+            loading={connect.isLoading}
+            onSubmit={({formData}) => {
+              console.log('resource form submitted', formData)
+              connect.mutate({connectorConfigId: ccfg.id, settings: formData})
+            }}
+            hideSubmitButton
+          />
+        </div>
+        <DialogFooter className="flex-shrink-0">
           <Button
             disabled={connect.isLoading}
             onClick={() => formRef.current?.submit()}
diff --git a/packages/ui/components/SchemaForm.tsx b/packages/ui/components/SchemaForm.tsx
index 3adabfd9..110c4284 100644
--- a/packages/ui/components/SchemaForm.tsx
+++ b/packages/ui/components/SchemaForm.tsx
@@ -101,7 +101,7 @@ export const SchemaForm = React.forwardRef(function SchemaForm<
         'schema-form',
         loading && 'loading',
         props.className,
-        'max-h-[450px] overflow-y-auto',
+        'overflow-y-auto',
       )}
       schema={jsonSchema}
       validator={validator}