From 7fe7eda8ce00887ad04918911b5de00d1b48c5e6 Mon Sep 17 00:00:00 2001 From: Stefan Charsley Date: Fri, 15 Nov 2024 09:42:34 +0000 Subject: [PATCH 1/2] change media type `vc+sd-jwt` to `dc+sd-jwt` Signed-off-by: Stefan Charsley --- examples/authorization_details_sd_jwt_vc.json | 2 +- examples/credential_metadata_sd_jwt_vc.json | 2 +- examples/credential_request_sd_jwt_vc.json | 2 +- examples/credential_response_sd_jwt_vc.txt | 6 +++--- openid-4-verifiable-credential-issuance-1_0.md | 11 ++++++----- 5 files changed, 12 insertions(+), 11 deletions(-) diff --git a/examples/authorization_details_sd_jwt_vc.json b/examples/authorization_details_sd_jwt_vc.json index c47fc86b..8ac8998e 100644 --- a/examples/authorization_details_sd_jwt_vc.json +++ b/examples/authorization_details_sd_jwt_vc.json @@ -1,7 +1,7 @@ [ { "type": "openid_credential", - "format": "vc+sd-jwt", + "format": "dc+sd-jwt", "vct": "SD_JWT_VC_example_in_OpenID4VCI" } ] \ No newline at end of file diff --git a/examples/credential_metadata_sd_jwt_vc.json b/examples/credential_metadata_sd_jwt_vc.json index 2cd813d5..818ea836 100644 --- a/examples/credential_metadata_sd_jwt_vc.json +++ b/examples/credential_metadata_sd_jwt_vc.json @@ -1,7 +1,7 @@ { "credential_configurations_supported": { "SD_JWT_VC_example_in_OpenID4VCI": { - "format": "vc+sd-jwt", + "format": "dc+sd-jwt", "scope": "SD_JWT_VC_example_in_OpenID4VCI", "cryptographic_binding_methods_supported": [ "jwk" diff --git a/examples/credential_request_sd_jwt_vc.json b/examples/credential_request_sd_jwt_vc.json index a4a5fd0a..21426095 100644 --- a/examples/credential_request_sd_jwt_vc.json +++ b/examples/credential_request_sd_jwt_vc.json @@ -1,5 +1,5 @@ { - "format": "vc+sd-jwt", + "format": "dc+sd-jwt", "vct": "SD_JWT_VC_example_in_OpenID4VCI", "proof": { "proof_type": "jwt", diff --git a/examples/credential_response_sd_jwt_vc.txt b/examples/credential_response_sd_jwt_vc.txt index 3862a5db..7a494a68 100644 --- a/examples/credential_response_sd_jwt_vc.txt +++ b/examples/credential_response_sd_jwt_vc.txt @@ -5,7 +5,7 @@ Cache-Control: no-store { "credentials": [ { - "credential": "eyJhbGciOiAiRVMyNTYiLCAidHlwIjogInZjK3NkLWp3d + "credential": "eyJhbGciOiAiRVMyNTYiLCAidHlwIjogImRjK3NkLWp3d CIsICJraWQiOiAiZG9jLXNpZ25lci0wNS0yNS0yMDIyIn0.eyJfc2QiOiBbI jA5dktySk1PbHlUV00wc2pwdV9wZE9CVkJRMk0xeTNLaHBINTE1blhrcFkiL CAiMnJzakdiYUMwa3k4bVQwcEpyUGlvV1RxMF9kYXcxc1g3NnBvVWxnQ3diS @@ -23,8 +23,8 @@ Cache-Control: no-store mYiOiB7Imp3ayI6IHsia3R5IjogIkVDIiwgImNydiI6ICJQLTI1NiIsICJ4I jogIlRDQUVSMTladnUzT0hGNGo0VzR2ZlNWb0hJUDFJTGlsRGxzN3ZDZUdlb WMiLCAieSI6ICJaeGppV1diWk1RR0hWV0tWUTRoYlNJaXJzVmZ1ZWNDRTZ0N - GpUOUYySFpRIn19fQ.oiDeF5QD8nCi8NHpKCVBsyitThK1xdRPtMePDdEIqJ - FY1BKtd5PhYjXLUVg3VuQZqyuOUev0OQAgu1KuMY0DNA~WyIyR0xDNDJzS1F + GpUOUYySFpRIn19fQ.dVjA0sh4xGD32uPqc9h4WHiEL3A08kiKNE08IIrtn3 + PJvljLU7n19LBTtuzPFZoc_GoPuS97SIDbz96K8pkZew~WyIyR0xDNDJzS1F 2ZUNmR2ZyeU5STjl3IiwgImdpdmVuX25hbWUiLCAiSm9obiJd~WyJlbHVWNU 9nM2dTTklJOEVZbnN4QV9BIiwgImZhbWlseV9uYW1lIiwgIkRvZSJd~WyI2S Wo3dE0tYTVpVlBHYm9TNXRtdlZBIiwgImVtYWlsIiwgImpvaG5kb2VAZXhhb diff --git a/openid-4-verifiable-credential-issuance-1_0.md b/openid-4-verifiable-credential-issuance-1_0.md index 0bb07030..cc894cac 100644 --- a/openid-4-verifiable-credential-issuance-1_0.md +++ b/openid-4-verifiable-credential-issuance-1_0.md @@ -2206,7 +2206,7 @@ This section defines a Credential Format Profile for Credentials complying with ### Format Identifier -The Credential Format Identifier is `vc+sd-jwt`. +The Credential Format Identifier is `dc+sd-jwt`. ### Credential Issuer Metadata {#server-metadata-sd-jwt-vc} @@ -2224,7 +2224,7 @@ The following additional Credential Issuer metadata parameters are defined for t * `locale`: OPTIONAL. String value that identifies language of this object represented as language tag values defined in BCP47 [@!RFC5646]. There MUST be only one object for each language identifier. * `order`: OPTIONAL. An array of the claim name values that lists them in the order they should be displayed by the Wallet. -The following is a non-normative example of an object comprising the `credential_configurations_supported` parameter for Credential Format `vc+sd-jwt`. +The following is a non-normative example of an object comprising the `credential_configurations_supported` parameter for Credential Format `dc+sd-jwt`. <{{examples/credential_metadata_sd_jwt_vc.json}} @@ -2235,7 +2235,7 @@ The following additional claims are defined for authorization details of type `o * `vct`: REQUIRED. String as defined in (#server-metadata-sd-jwt-vc). This claim contains the type values the Wallet requests authorization for at the Credential Issuer. It MUST only be present if the `format` claim is present. It MUST not be present otherwise. * `claims`: OPTIONAL. Object as defined in (#server-metadata-sd-jwt-vc) excluding the `display` and `value_type` parameters. `mandatory` parameter here is used by the Wallet to indicate to the Issuer that it only accepts Credential(s) issued with those claim(s). -The following is a non-normative example of an authorization details object with Credential Format `vc+sd-jwt`. +The following is a non-normative example of an authorization details object with Credential Format `dc+sd-jwt`. <{{examples/authorization_details_sd_jwt_vc.json}} @@ -2245,7 +2245,7 @@ The following additional parameters are defined for Credential Requests and this * `vct`: REQUIRED when the `format` parameter is present in the Credential Request. It MUST NOT be used otherwise. It is a string as defined in (#server-metadata-sd-jwt-vc). This claim contains the type value of the Credential that the Wallet requests the Credential Issuer to issue. -The following is a non-normative example of a Credential Request with Credential Format `vc+sd-jwt`. +The following is a non-normative example of a Credential Request with Credential Format `dc+sd-jwt`. <{{examples/credential_request_sd_jwt_vc.json}} @@ -2253,7 +2253,7 @@ The following is a non-normative example of a Credential Request with Credential The value of the `credential` claim in the Credential Response MUST be a string that is an SD-JWT VC. Credentials of this format are already suitable for transfer and, therefore, they need not and MUST NOT be re-encoded. -The following is a non-normative example of a Credential Response containing a Credential of format `vc+sd-jwt`. +The following is a non-normative example of a Credential Response containing a Credential of format `dc+sd-jwt`. <{{examples/credential_response_sd_jwt_vc.txt}} @@ -2462,6 +2462,7 @@ The technology described in this specification was made available from contribut * Fixed #375: Enabled non-breaking extensibility * removes `c_nonce` and `c_nonce_expires_in` from the Credential Error Response * Fixed #239: Completed IANA Considerations section + * change media type `vc+sd-jwt` to `dc+sd-jwt` to align with draft 06 of [@!I-D.ietf-oauth-sd-jwt-vc] -14 From aaa442d314c0e9d5cfb88673d0ed5b433d420cff Mon Sep 17 00:00:00 2001 From: Stefan Charsley Date: Tue, 19 Nov 2024 20:22:43 +0000 Subject: [PATCH 2/2] apply changes from pr review Signed-off-by: Stefan Charsley --- openid-4-verifiable-credential-issuance-1_0.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openid-4-verifiable-credential-issuance-1_0.md b/openid-4-verifiable-credential-issuance-1_0.md index 7358e80c..f00d69a6 100644 --- a/openid-4-verifiable-credential-issuance-1_0.md +++ b/openid-4-verifiable-credential-issuance-1_0.md @@ -2571,7 +2571,7 @@ The technology described in this specification was made available from contribut * removes `c_nonce` and `c_nonce_expires_in` from the Credential Error Response * Fixed #239: Completed IANA Considerations section * add key attestation as additional information in a proof of possesion and new proof type - * change media type `vc+sd-jwt` to `dc+sd-jwt` to align with draft 06 of [@!I-D.ietf-oauth-sd-jwt-vc] + * change credential format identifier `vc+sd-jwt` to `dc+sd-jwt` to align with the media type in draft -06 of [@I-D.ietf-oauth-sd-jwt-vc] and update `typ` accordingly in examples -14