From 873fdfbfeb93cef27f17d4bfe1bbe23dd4aaa8cb Mon Sep 17 00:00:00 2001 From: Kristina <=> Date: Fri, 8 Dec 2023 16:41:56 -0800 Subject: [PATCH 1/7] clarify logo_uri can be of multiple schemes --- openid-4-verifiable-credential-issuance-1_0.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openid-4-verifiable-credential-issuance-1_0.md b/openid-4-verifiable-credential-issuance-1_0.md index d3a60c7f..d77a4508 100644 --- a/openid-4-verifiable-credential-issuance-1_0.md +++ b/openid-4-verifiable-credential-issuance-1_0.md @@ -1220,7 +1220,7 @@ This specification defines the following Credential Issuer Metadata: * `name`: REQUIRED. String value of a display name for the Credential. * `locale`: OPTIONAL. String value that identifies the language of this object represented as a language tag taken from values defined in BCP47 [@!RFC5646]. Multiple `display` objects MAY be included for separate languages. There MUST be only one object for each language identifier. * `logo`: OPTIONAL. A JSON object with information about the logo of the Credential with a following non-exhaustive list of parameters that MAY be included: - * `url`: OPTIONAL. URL where the Wallet can obtain a logo of the Credential from the Credential Issuer. + * `uri`: OPTIONAL. String value that contains a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to determine the scheme, since the URI value could use `https:` scheme, `data:` scheme, etc. * `alt_text`: OPTIONAL. String value of an alternative text of a logo image. * `description`: OPTIONAL. String value of a description of the Credential. * `background_color`: OPTIONAL. String value of a background color of the Credential represented as numerical color values defined in CSS Color Module Level 37 [@!CSS-Color]. From 64968a8a5f47559989cf35f889079be57c60e767 Mon Sep 17 00:00:00 2001 From: Kristina <=> Date: Mon, 18 Dec 2023 05:13:45 -0800 Subject: [PATCH 2/7] add logo image for the credential issuer and change uri to an array --- openid-4-verifiable-credential-issuance-1_0.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/openid-4-verifiable-credential-issuance-1_0.md b/openid-4-verifiable-credential-issuance-1_0.md index 7bbce0b4..194b3404 100644 --- a/openid-4-verifiable-credential-issuance-1_0.md +++ b/openid-4-verifiable-credential-issuance-1_0.md @@ -1264,7 +1264,7 @@ This specification defines the following Credential Issuer Metadata: * `name`: REQUIRED. String value of a display name for the Credential. * `locale`: OPTIONAL. String value that identifies the language of this object represented as a language tag taken from values defined in BCP47 [@!RFC5646]. Multiple `display` objects MAY be included for separate languages. There MUST be only one object for each language identifier. * `logo`: OPTIONAL. A JSON object with information about the logo of the Credential with a following non-exhaustive list of parameters that MAY be included: - * `uri`: OPTIONAL. String value that contains a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to determine the scheme, since the URI value could use `https:` scheme, `data:` scheme, etc. + * `uri`: OPTIONAL. Array of values that each identify a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to identify and pick the scheme that it supports, since the URI value could use `https:` scheme, `data:` scheme, etc. * `alt_text`: OPTIONAL. String value of an alternative text of a logo image. * `description`: OPTIONAL. String value of a description of the Credential. * `background_color`: OPTIONAL. String value of a background color of the Credential represented as numerical color values defined in CSS Color Module Level 37 [@!CSS-Color]. @@ -1846,6 +1846,9 @@ The following additional Credential Issuer metadata are defined for this Credent * `display`: OPTIONAL. An array of objects, where each object contains display properties of a certain claim in the Credential for a certain language. Below is a non-exhaustive list of valid parameters that MAY be included: * `name`: OPTIONAL. String value of a display name for the claim. * `locale`: OPTIONAL. String value that identifies language of this object represented as language tag values defined in BCP47 [@!RFC5646]. There MUST be only one object for each language identifier. + * `logo`: OPTIONAL. A JSON object with information about the logo of the Credential Issuer with a following non-exhaustive list of parameters that MAY be included: + * `uri`: OPTIONAL. Array of values that each identify a URI where the Wallet can obtain a logo of the Credential Issuer. Wallet needs to identify and pick the scheme that it supports, since the URI value could use `https:` scheme, `data:` scheme, etc. + * `alt_text`: OPTIONAL. String value of an alternative text of a logo image. * `order`: OPTIONAL. An array of the claim name values that lists them in the order they should be displayed by the Wallet. The following is a non-normative example of an object comprising `credentials_supported` parameter of Credential format `jwt_vc_json`: From b2f91cf934585e843d3add5ff5b15527f9f5c0e5 Mon Sep 17 00:00:00 2001 From: Kristina <=> Date: Mon, 18 Dec 2023 05:14:18 -0800 Subject: [PATCH 3/7] change param name to uris --- openid-4-verifiable-credential-issuance-1_0.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/openid-4-verifiable-credential-issuance-1_0.md b/openid-4-verifiable-credential-issuance-1_0.md index 194b3404..3f7be007 100644 --- a/openid-4-verifiable-credential-issuance-1_0.md +++ b/openid-4-verifiable-credential-issuance-1_0.md @@ -1264,7 +1264,7 @@ This specification defines the following Credential Issuer Metadata: * `name`: REQUIRED. String value of a display name for the Credential. * `locale`: OPTIONAL. String value that identifies the language of this object represented as a language tag taken from values defined in BCP47 [@!RFC5646]. Multiple `display` objects MAY be included for separate languages. There MUST be only one object for each language identifier. * `logo`: OPTIONAL. A JSON object with information about the logo of the Credential with a following non-exhaustive list of parameters that MAY be included: - * `uri`: OPTIONAL. Array of values that each identify a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to identify and pick the scheme that it supports, since the URI value could use `https:` scheme, `data:` scheme, etc. + * `uris`: OPTIONAL. Array of values that each identify a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to identify and pick the scheme that it supports, since the URI value could use `https:` scheme, `data:` scheme, etc. * `alt_text`: OPTIONAL. String value of an alternative text of a logo image. * `description`: OPTIONAL. String value of a description of the Credential. * `background_color`: OPTIONAL. String value of a background color of the Credential represented as numerical color values defined in CSS Color Module Level 37 [@!CSS-Color]. @@ -1847,7 +1847,7 @@ The following additional Credential Issuer metadata are defined for this Credent * `name`: OPTIONAL. String value of a display name for the claim. * `locale`: OPTIONAL. String value that identifies language of this object represented as language tag values defined in BCP47 [@!RFC5646]. There MUST be only one object for each language identifier. * `logo`: OPTIONAL. A JSON object with information about the logo of the Credential Issuer with a following non-exhaustive list of parameters that MAY be included: - * `uri`: OPTIONAL. Array of values that each identify a URI where the Wallet can obtain a logo of the Credential Issuer. Wallet needs to identify and pick the scheme that it supports, since the URI value could use `https:` scheme, `data:` scheme, etc. + * `uris`: OPTIONAL. Array of values that each identify a URI where the Wallet can obtain a logo of the Credential Issuer. Wallet needs to identify and pick the scheme that it supports, since the URI value could use `https:` scheme, `data:` scheme, etc. * `alt_text`: OPTIONAL. String value of an alternative text of a logo image. * `order`: OPTIONAL. An array of the claim name values that lists them in the order they should be displayed by the Wallet. From 2edb4990e1c4f262c53b4eb084b9b51ddb616881 Mon Sep 17 00:00:00 2001 From: Kristina <52878547+Sakurann@users.noreply.github.com> Date: Thu, 21 Dec 2023 08:32:47 -0800 Subject: [PATCH 4/7] fall back to a string --- openid-4-verifiable-credential-issuance-1_0.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/openid-4-verifiable-credential-issuance-1_0.md b/openid-4-verifiable-credential-issuance-1_0.md index 3f7be007..d568c259 100644 --- a/openid-4-verifiable-credential-issuance-1_0.md +++ b/openid-4-verifiable-credential-issuance-1_0.md @@ -1264,7 +1264,7 @@ This specification defines the following Credential Issuer Metadata: * `name`: REQUIRED. String value of a display name for the Credential. * `locale`: OPTIONAL. String value that identifies the language of this object represented as a language tag taken from values defined in BCP47 [@!RFC5646]. Multiple `display` objects MAY be included for separate languages. There MUST be only one object for each language identifier. * `logo`: OPTIONAL. A JSON object with information about the logo of the Credential with a following non-exhaustive list of parameters that MAY be included: - * `uris`: OPTIONAL. Array of values that each identify a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to identify and pick the scheme that it supports, since the URI value could use `https:` scheme, `data:` scheme, etc. + * `uri`: OPTIONAL. String value that contains a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to determine the scheme, since the URI value could use `https:` scheme, `data:` scheme, etc. * `alt_text`: OPTIONAL. String value of an alternative text of a logo image. * `description`: OPTIONAL. String value of a description of the Credential. * `background_color`: OPTIONAL. String value of a background color of the Credential represented as numerical color values defined in CSS Color Module Level 37 [@!CSS-Color]. @@ -1847,7 +1847,7 @@ The following additional Credential Issuer metadata are defined for this Credent * `name`: OPTIONAL. String value of a display name for the claim. * `locale`: OPTIONAL. String value that identifies language of this object represented as language tag values defined in BCP47 [@!RFC5646]. There MUST be only one object for each language identifier. * `logo`: OPTIONAL. A JSON object with information about the logo of the Credential Issuer with a following non-exhaustive list of parameters that MAY be included: - * `uris`: OPTIONAL. Array of values that each identify a URI where the Wallet can obtain a logo of the Credential Issuer. Wallet needs to identify and pick the scheme that it supports, since the URI value could use `https:` scheme, `data:` scheme, etc. + * `uri`: OPTIONAL. String value that contains a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to determine the scheme, since the URI value could use `https:` scheme, `data:` scheme, etc. * `alt_text`: OPTIONAL. String value of an alternative text of a logo image. * `order`: OPTIONAL. An array of the claim name values that lists them in the order they should be displayed by the Wallet. From 81af7de2e2e96ca5e07ffcf4738c04fba45b9fb8 Mon Sep 17 00:00:00 2001 From: Kristina <=> Date: Fri, 22 Dec 2023 15:27:28 -0800 Subject: [PATCH 5/7] move credential issuer logo_uri to a correct place --- openid-4-verifiable-credential-issuance-1_0.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/openid-4-verifiable-credential-issuance-1_0.md b/openid-4-verifiable-credential-issuance-1_0.md index 7ff735a8..dba14cd8 100644 --- a/openid-4-verifiable-credential-issuance-1_0.md +++ b/openid-4-verifiable-credential-issuance-1_0.md @@ -1342,6 +1342,9 @@ This specification defines the following Credential Issuer Metadata: * `display`: OPTIONAL. Array of objects, where each object contains display properties of a Credential Issuer for a certain language. Below is a non-exhaustive list of valid parameters that MAY be included: * `name`: OPTIONAL. String value of a display name for the Credential Issuer. * `locale`: OPTIONAL. String value that identifies the language of this object represented as a language tag taken from values defined in BCP47 [@!RFC5646]. There MUST be only one object for each language identifier. + * `logo`: OPTIONAL. A JSON object with information about the logo of the Credential Issuer with a following non-exhaustive list of parameters that MAY be included: + * `uri`: OPTIONAL. String value that contains a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to determine the scheme, since the URI value could use `https:` scheme, `data:` scheme, etc. + * `alt_text`: OPTIONAL. String value of an alternative text of a logo image. * `credential_configurations_supported`: REQUIRED. Object that describes specifics of the Credential that the Credential Issuer supports issuance of. This object contains a list of name/value pairs, where each name is a unique identifier of the supported Credential being described. This identifier is used in the Credential Offer as defined in (#credential_offer_parameters) to communicate to the Wallet which Credential is being offered. The value is an object that contains metadata about specific Credential and contains the following parameters defined by this specification: * `format`: REQUIRED. A JSON string identifying the format of this Credential, i.e., `jwt_vc_json` or `ldp_vc`. Depending on the format value, the object contains further elements defining the type and (optionally) particular claims the Credential MAY contain and information about how to display the Credential. (#format_profiles) defines Credential Format Profiles introduced by this specification. * `scope`: OPTIONAL. A JSON string identifying the scope value that this Credential Issuer supports for this particular Credential. The value can be the same accross multiple `credential_configurations_supported` objects. The Authorization Server MUST be able to uniquely identify the Credential Issuer based on the scope value. The Wallet can use this value in the Authorization Request as defined in (#credential-request-using-type-specific-scope). Scope values in this Credential Issuer metadata MAY duplicate those in the `scopes_supported` parameter of the Authorization Server. @@ -2046,9 +2049,6 @@ The following additional Credential Issuer metadata are defined for this Credent * `display`: OPTIONAL. Array of objects, where each object contains display properties of a certain claim in the Credential for a certain language. Below is a non-exhaustive list of valid parameters that MAY be included: * `name`: OPTIONAL. String value of a display name for the claim. * `locale`: OPTIONAL. String value that identifies language of this object represented as language tag values defined in BCP47 [@!RFC5646]. There MUST be only one object for each language identifier. - * `logo`: OPTIONAL. A JSON object with information about the logo of the Credential Issuer with a following non-exhaustive list of parameters that MAY be included: - * `uri`: OPTIONAL. String value that contains a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to determine the scheme, since the URI value could use `https:` scheme, `data:` scheme, etc. - * `alt_text`: OPTIONAL. String value of an alternative text of a logo image. * `order`: OPTIONAL. Array of the claim name values that lists them in the order they should be displayed by the Wallet. The following is a non-normative example of an object comprising `credential_configurations_supported` parameter of Credential format `jwt_vc_json`: From 87a5921506f83021f8d5d689d3829513d1492c8f Mon Sep 17 00:00:00 2001 From: Kristina <=> Date: Fri, 22 Dec 2023 15:28:39 -0800 Subject: [PATCH 6/7] remove issuer logo from this PR to turn into another PR --- openid-4-verifiable-credential-issuance-1_0.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/openid-4-verifiable-credential-issuance-1_0.md b/openid-4-verifiable-credential-issuance-1_0.md index dba14cd8..06bdbf94 100644 --- a/openid-4-verifiable-credential-issuance-1_0.md +++ b/openid-4-verifiable-credential-issuance-1_0.md @@ -1342,9 +1342,6 @@ This specification defines the following Credential Issuer Metadata: * `display`: OPTIONAL. Array of objects, where each object contains display properties of a Credential Issuer for a certain language. Below is a non-exhaustive list of valid parameters that MAY be included: * `name`: OPTIONAL. String value of a display name for the Credential Issuer. * `locale`: OPTIONAL. String value that identifies the language of this object represented as a language tag taken from values defined in BCP47 [@!RFC5646]. There MUST be only one object for each language identifier. - * `logo`: OPTIONAL. A JSON object with information about the logo of the Credential Issuer with a following non-exhaustive list of parameters that MAY be included: - * `uri`: OPTIONAL. String value that contains a URI where the Wallet can obtain a logo of the Credential from the Credential Issuer. Wallet needs to determine the scheme, since the URI value could use `https:` scheme, `data:` scheme, etc. - * `alt_text`: OPTIONAL. String value of an alternative text of a logo image. * `credential_configurations_supported`: REQUIRED. Object that describes specifics of the Credential that the Credential Issuer supports issuance of. This object contains a list of name/value pairs, where each name is a unique identifier of the supported Credential being described. This identifier is used in the Credential Offer as defined in (#credential_offer_parameters) to communicate to the Wallet which Credential is being offered. The value is an object that contains metadata about specific Credential and contains the following parameters defined by this specification: * `format`: REQUIRED. A JSON string identifying the format of this Credential, i.e., `jwt_vc_json` or `ldp_vc`. Depending on the format value, the object contains further elements defining the type and (optionally) particular claims the Credential MAY contain and information about how to display the Credential. (#format_profiles) defines Credential Format Profiles introduced by this specification. * `scope`: OPTIONAL. A JSON string identifying the scope value that this Credential Issuer supports for this particular Credential. The value can be the same accross multiple `credential_configurations_supported` objects. The Authorization Server MUST be able to uniquely identify the Credential Issuer based on the scope value. The Wallet can use this value in the Authorization Request as defined in (#credential-request-using-type-specific-scope). Scope values in this Credential Issuer metadata MAY duplicate those in the `scopes_supported` parameter of the Authorization Server. From a94aa5e838a5bee5dd12df84e0853e1bad46e35b Mon Sep 17 00:00:00 2001 From: Kristina <=> Date: Fri, 22 Dec 2023 15:34:08 -0800 Subject: [PATCH 7/7] add history entry --- openid-4-verifiable-credential-issuance-1_0.md | 1 + 1 file changed, 1 insertion(+) diff --git a/openid-4-verifiable-credential-issuance-1_0.md b/openid-4-verifiable-credential-issuance-1_0.md index 06bdbf94..0f03f9ec 100644 --- a/openid-4-verifiable-credential-issuance-1_0.md +++ b/openid-4-verifiable-credential-issuance-1_0.md @@ -2292,6 +2292,7 @@ The value of the `credential` claim in the Credential Response MUST be a string -13 + * clarified that logo can is a uri and not a url only * added a Notification Endpoint used by the Wallet to notify the Credential Issuer of certain events for issued Credentials * completed IANA registrations section * clarified description of a `mandatory` claim