Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session binding when using same-device direct_post with redirect_uri #50

Open
OIDF-automation opened this issue Jul 14, 2023 · 4 comments · May be fixed by #449
Open

session binding when using same-device direct_post with redirect_uri #50

OIDF-automation opened this issue Jul 14, 2023 · 4 comments · May be fixed by #449
Labels
has-PR
Milestone
Final 1.0

Comments

@OIDF-automation
Copy link
Contributor

Imported from AB/Connect bitbucket: https://bitbucket.org/openid/connect/issues/1988

Original Reporter: fabian-hk

The Verifiable Credential Issuance spec says in section 11.2 that certain checks should be performed upon receipt of a credential offer. Since there is no list of checks and no reference to another section, I was wondering what kind of checks a wallet could do without knowing anything about the credential offer?
@OIDF-automation
Copy link
Contributor Author

Imported from AB/Connect bitbucket - Original Commenter: mbj

Submitted -> New

@OIDF-automation
Copy link
Contributor Author

Imported from AB/Connect bitbucket - Original Commenter: KristinaYasuda

The Wallet MUST apply the same checks on the Credential Issuer that it would apply when the flow is started from the Wallet itself since the Credential Issuer is not trustworthy just because it sent the Credential Offer.

is this the text you are referring to? I think it is pretty clear that “checks are on the Credential Issuer” - getting Issuer metadata, checking if the Issuer is a trusted issuer or not, etc.

‌

@OIDF-automation
Copy link
Contributor Author

Imported from AB/Connect bitbucket - Original Commenter: KristinaYasuda

was the question answered..?

@OIDF-automation
Copy link
Contributor Author

Imported from AB/Connect bitbucket - Original Commenter: fabian-hk

Yes, thank you, but I think this is a little unclear in the spec.

@Sakurann Sakurann changed the title Checks in Section 11.2 session binding when using same-device direct_post with redirect_uri Sep 7, 2023
@Sakurann Sakurann added ready-for-PR and removed bug labels Sep 7, 2023
@Sakurann Sakurann linked a pull request Jan 22, 2025 that will close this issue
Open
@Sakurann Sakurann added this to the Final 1.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has-PR
Projects
None yet
Milestone
Final 1.0
Development

Successfully merging a pull request may close this issue.

clarify what checks wallet performs after receiving credential offer openid/OpenID4VCI
2 participants
@Sakurann @OIDF-automation