Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorial: Credential response Encrypted, is it possibile having a nested JWT? #154

Open
peppelinux opened this issue Dec 15, 2023 · 5 comments
Milestone

Comments

@peppelinux
Copy link
Member

The response is an encrypted json and not a Netsted JWT, signed and then encrypted.

Is there any possibility that implementers look for having a Nested JWT? Probably not.

I would give more clarification, as OIDC with the userinfo response (or id token) made:

If the UserInfo Response is signed and/or encrypted, then the Claims are returned in a JWT and the content-type MUST be application/jwt. The response MAY be encrypted without also being signed. If both signing and encryption are requested, the response MUST be signed then encrypted, with the result being a Nested JWT, as defined in [JWT].

@sakimura @selfissued ^

Originally posted by @peppelinux in #136 (comment)

@peppelinux peppelinux changed the title editorial: Credential response Encrypted, is it possibile having a ested JWT? editorial: Credential response Encrypted, is it possibile having a nested JWT? Dec 15, 2023
@selfissued
Copy link
Member

https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0-12.html#name-credential-response already describes unencrypted JSON responses and encrypted JWT responses.

The only reason you might have a nested JWT in my mind would be if the response is signed. But that isn't described in the spec, nor have I heard a request to be able to do so. The credentials themselves, are of course signed.

It would be OK to be 100% clear that for encrypted responses, the JSON response body is the JWT Claims Set. That currently seems to be implied but not explicitly stated.

@peppelinux
Copy link
Member Author

@selfissued you words exactly explain the purpose of this issue that aims to introduce in the current document some explicit text about this.

@Sakurann
Copy link
Collaborator

@peppelinux are you asking for an explicit text that Credential response cannot be a nested JWT because entire response is encrypted and signed credentials are contained as claims in the encrypted payload?

@Sakurann
Copy link
Collaborator

Do we need a whole section in VCI on how to encrypt credential response without signing the whole payload again?

something like only encrypted JARM in VP? https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-8.3-2

cc @bc-pi

@Sakurann Sakurann added this to the Final 1.0 milestone Jan 22, 2025
@bc-pi
Copy link
Member

bc-pi commented Jan 22, 2025

Do we need a whole section in VCI on how to encrypt credential response without signing the whole payload again?

That's what is already there as far as I understand.

something like only encrypted JARM in VP? https://openid.github.io/OpenID4VP/openid-4-verifiable-presentations-wg-draft.html#section-8.3-2

no

cc @bc-pi

I'm honestly having a hard time understanding why this issue exists or what is being asked.

@Sakurann Sakurann modified the milestones: Final 1.0, 1.1 Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants