Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the parameter wallet_issuer be changed to wallet_provider? #103

Open
peppelinux opened this issue Nov 6, 2023 · 3 comments
Open
Assignees
Labels
Milestone

Comments

@peppelinux
Copy link
Member

          WDYT about?

wallet_issuer -> wallet_provider

it seems more closer to the current language

Originally posted by @peppelinux in #98 (comment)

@Sakurann
Copy link
Collaborator

Sakurann commented Dec 8, 2023

I think _issuer was originally used because it was meant for as an equivalent of OAuth 2.0 issuer parameter, just like credential_issuer. but I agree that wallet_issuer as a whole is probably not a term that is widely used or understood and wallet_provider is probably better.
@pmhsfelix, @tlodderstedt ?

@peppelinux
Copy link
Member Author

In the PR #142 I've proposed the parameter name wallet_id to uniquely identifying a wallet instance.

I correct myself by saying that the term Wallet Provider has a mean different from the Wallet instance.

The name wallet_id is more flexible and it means exactly a wallet identifier. This can be used for doing the discovery process defined in SIOPv2. Nothing prevents a wallet instance to provide its wallet provider unique identifier in the wallet_id value, if the wallet capabilities and endpoints are provided in the cloud by the wallet provider.

@selfissued
Copy link
Member

There's also a discussion in #142 about whether we need a wallet identifier at all distinct from the Client ID.

@Sakurann Sakurann modified the milestones: ID-1, post ID-1 Jan 16, 2024
@Sakurann Sakurann modified the milestones: post ID-1, Final 1.0 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants