From 00a2614f85823f5012136776b199a62a1a6d5b85 Mon Sep 17 00:00:00 2001 From: lleeoo Date: Wed, 24 Jan 2024 19:23:36 +0100 Subject: [PATCH] cleaning and linting --- .../models/edx/converters/xapi/test_video.py | 20 +++++-------------- .../open_response_assessment/test_events.py | 2 +- tests/models/test_validator.py | 4 +--- tests/models/xapi/base/test_statements.py | 12 +++-------- 4 files changed, 10 insertions(+), 28 deletions(-) diff --git a/tests/models/edx/converters/xapi/test_video.py b/tests/models/edx/converters/xapi/test_video.py index b7185ffac..0c3d27698 100644 --- a/tests/models/edx/converters/xapi/test_video.py +++ b/tests/models/edx/converters/xapi/test_video.py @@ -32,9 +32,7 @@ def test_models_edx_converters_xapi_video_ui_load_video_to_video_initialized( expected xAPI statement. """ event = mock_instance(UILoadVideo) - event.context.course_id = ( - "course-v1:a+b+c" # TODO: see why generation does not work and remove this - ) + event.context.course_id = "course-v1:a+b+c" platform_url = mock_url() @@ -93,9 +91,7 @@ def test_models_edx_converters_xapi_video_ui_play_video_to_video_played(uuid_nam xAPI statement. """ event = mock_instance(UIPlayVideo) - event.context.course_id = ( - "course-v1:a+b+c" # TODO: see why generation does not work and remove this - ) + event.context.course_id = "course-v1:a+b+c" platform_url = mock_url() @@ -160,9 +156,7 @@ def test_models_edx_converters_xapi_video_ui_pause_video_to_video_paused( statement. """ event = mock_instance(UIPauseVideo) - event.context.course_id = ( - "course-v1:a+b+c" # TODO: see why generation does not work and remove this - ) + event.context.course_id = "course-v1:a+b+c" platform_url = mock_url() @@ -228,9 +222,7 @@ def test_models_edx_converters_xapi_video_ui_stop_video_to_video_terminated( xAPI statement. """ event = mock_instance(UIStopVideo) - event.context.course_id = ( - "course-v1:a+b+c" # TODO: see why generation does not work and remove this - ) + event.context.course_id = "course-v1:a+b+c" platform_url = mock_url() @@ -295,9 +287,7 @@ def test_models_edx_converters_xapi_video_ui_seek_video_to_video_seeked(uuid_nam xAPI statement. """ event = mock_instance(UISeekVideo) - event.context.course_id = ( - "course-v1:a+b+c" # TODO: see why generation does not work and remove this - ) + event.context.course_id = "course-v1:a+b+c" platform_url = mock_url() diff --git a/tests/models/edx/open_response_assessment/test_events.py b/tests/models/edx/open_response_assessment/test_events.py index 521ee7b2c..e9dc3c19c 100644 --- a/tests/models/edx/open_response_assessment/test_events.py +++ b/tests/models/edx/open_response_assessment/test_events.py @@ -27,7 +27,7 @@ def test_models_edx_ora_get_peer_submission_event_field_with_valid_values(): ) -def test_models_edx_ora_get_submission_for_staff_grading_event_field_with_valid_values(): +def test_models_edx_ora_get_submission_for_staff_grading_event_field_with_valid_values(): # noqa: E501 """Test that a valid `ORAGetSubmissionForStaffGradingEventField` does not raise a `ValidationError`. """ diff --git a/tests/models/test_validator.py b/tests/models/test_validator.py index 259f22a74..a2db71d5d 100644 --- a/tests/models/test_validator.py +++ b/tests/models/test_validator.py @@ -119,9 +119,7 @@ def test_models_validator_validate_with_an_invalid_page_close_event_writes_an_er ) with caplog.at_level(logging.ERROR): assert not list(result) - errors = [ - "Input event is not valid." - ] + errors = ["Input event is not valid."] assert errors == [message for _, _, message in caplog.record_tuples] diff --git a/tests/models/xapi/base/test_statements.py b/tests/models/xapi/base/test_statements.py index 62ce7d993..156188e01 100644 --- a/tests/models/xapi/base/test_statements.py +++ b/tests/models/xapi/base/test_statements.py @@ -56,9 +56,7 @@ def test_models_xapi_base_statement_with_invalid_null_values(path, value): "context__extensions__https://w3id.org/xapi/video", ], ) -@pytest.mark.parametrize( - "value", [None, {}] -) +@pytest.mark.parametrize("value", [None, {}]) def test_models_xapi_base_statement_with_valid_null_values(path, value): """Test that the statement does accept valid null values in extensions fields. @@ -363,9 +361,7 @@ def test_models_xapi_base_statement_with_invalid_group_objects(klass): kwargs = {"exclude_none": True} statement = statement.model_dump(**kwargs) - statement["actor"]["member"] = [ - mock_xapi_instance(klass).model_dump(**kwargs) - ] + statement["actor"]["member"] = [mock_xapi_instance(klass).model_dump(**kwargs)] for class_ in [ "BaseXapiAgentWithMbox", @@ -571,9 +567,7 @@ def test_models_xapi_base_statement_should_consider_valid_all_defined_xapi_model # All specific xAPI models should inherit BaseXapiStatement assert issubclass(model, BaseXapiStatement) statement = mock_xapi_instance(model) - statement = statement.json( - exclude_none=True, by_alias=True - ) + statement = statement.json(exclude_none=True, by_alias=True) try: BaseXapiStatement(**json.loads(statement)) except ValidationError as err: