Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App should indicate ingredients are supplied by the producer (and can't be edited) #6101

Closed
alexgarel opened this issue Jan 2, 2025 · 13 comments · Fixed by #6156
Closed
Assignees

Comments

@alexgarel
Copy link
Member

alexgarel commented Jan 2, 2025

What

Reported on slack: The ingredients list might be supplied by the producer, in which case it is not editable. On nutrition we have a small factory logo for that, but there is no indications for ingredients.

Steps to reproduce the behavior

  1. Scan this product https://world.openfoodfacts.org/product/3560070614202/oat-flakes-carrefour
  2. Go to modify
  3. Ingredients
  4. No factory icon indicates that this is supplied by the producer
@monsieurtanuki
Copy link
Contributor

Indeed we should, and we already have the flags for that in https://fr.openfoodfacts.org/api/v3/product/3560070614202?fields=owner_fields:

            "ingredients_text_en": 1721360743,
            "ingredients_text_es": 1721360743,
            "ingredients_text_fr": 1721360743,
            "ingredients_text_it": 1721360743,
            "ingredients_text_nl": 1721360743,
            "ingredients_text_pl": 1721360743,
            "ingredients_text_ro": 1721360743,

I'm glad that users do understand the meaning of the factory logo.

@github-throwaway
Copy link

github-throwaway commented Jan 6, 2025

Is this shown in the app as well? I can't seem to find the factory icon 🙈

Image 2 Image 3 Image 4

@monsieurtanuki
Copy link
Contributor

@github-throwaway Don't hesitate to mention the barcode you're using for your screenshots.
The factory logo appears only in the "edit" pages. It's supposed to be there in your last screenshot, assuming that the nutrition facts are provided by the producer.

@github-throwaway
Copy link

I used the product mentioned above: https://world.openfoodfacts.org/product/3560070614202/oat-flakes-carrefour

@g123k
Copy link
Collaborator

g123k commented Jan 6, 2025

In this issue, it's for ingredients and not for the nutrition facts.
And the owner field is perfectly visible, eg with this product: https://fr.openfoodfacts.org/produit/3564700169643/mini-cakes-aux-fruits-p-tit-deli

@github-throwaway
Copy link

github-throwaway commented Jan 6, 2025

Yup. I got that part. I was just curious what the factory icon looks like. Because I don't see it. Or am I blind?😅

image

image

@g123k
Copy link
Collaborator

g123k commented Jan 6, 2025

The idea behind this issue is to add it to the app 🙃
You can't find it now.

@github-throwaway
Copy link

Ah. I thought "On nutrition we have a small factory logo for that, but there is no indications for ingredients." means that it is already implement for the nutrition page. My bad. Sorry about the confusion 😄

@monsieurtanuki
Copy link
Contributor

@github-throwaway There is a factory logo in those pages.

The problem may be:

  • you use an old version of the app, without that factory logo being added
  • we recently had issues with logo colors, which may be the same color as the background
example 1 example 2
Image Image

@github-throwaway
Copy link

github-throwaway commented Jan 7, 2025

Ahhh. Then it's probably the version. How can I get the lastest version of there is no update available in the App Store? 😅

Also if the manufacturer provides the data wouldn't it be better to not show the option to edit at all? Cause the option to even get to that screen would lead the user to believe it would be possible to edit and then they realise they can't? What if the factory icon is displayed in the ingredients display dialogue instead?

Maybe even put a report a problem button below the ingredients? 🤔

Image 1 Image 2

@monsieurtanuki
Copy link
Contributor

Ahhh. Then it's probably the version. How can I get the lastest version of there is no update available in the App Store? 😅

Probably blocked by #6006

Also if the manufacturer provides the data wouldn't it be better to not show the option to edit at all? Cause the option to even get to that screen would lead the user to believe it would be possible to edit and then they realise they can't? What if the factory icon is displayed in the ingredients display dialogue instead?

Providing an access to the edit ingredients page may be helpful, if you want to copy the text or see the picture.
I don't know which would be better: hide the ingredients and break the consistency with other products, or put the factory logo.

Maybe even put a report a problem button below the ingredients? 🤔

Would make sense.

For the record we have limited control over the read-only page about ingredients, which is a "knowledge panel" provided by the server.

@github-throwaway Generally speaking, some of your questions go beyond the OP, which was about consistently displaying a factory logo for the edit ingredients page.
You should probably create specific issues for specific needs/questions.

@g123k g123k self-assigned this Jan 7, 2025
@g123k
Copy link
Collaborator

g123k commented Jan 7, 2025

The icon will be visible in an upcoming PR:
Image

@github-throwaway
Copy link

@g123k looks great! 😊

@g123k g123k linked a pull request Jan 8, 2025 that will close this issue
@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

5 participants