Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content banner action bar is not visible in some scenarios #563

Open
brummbar opened this issue Dec 8, 2023 · 2 comments
Open

Content banner action bar is not visible in some scenarios #563

brummbar opened this issue Dec 8, 2023 · 2 comments

Comments

@brummbar
Copy link

brummbar commented Dec 8, 2023

If the content banner has a parent element with the .container class and the banner itself has a class bg-lighter, the action bar markup will be hidden.
This can be reproduced by adding the container class to the #root wrapper here https://oelibrary.netlify.app/default/?path=/story/compositions-content-banner--default .
The rest of the card does not disappear as the z-index is handled correctly, but not for the action bar.

@brummbar
Copy link
Author

brummbar commented Dec 8, 2023

This is the same as discussed in #562 but in that issue the whole banner is hidden due to markup changes on the implementation side. On BCL level, only the action bar is impacted.

@kp77
Copy link
Contributor

kp77 commented Jan 5, 2024

Hi @brummbar,

We just updated to BCL 1.2.0 (from 1.0.2) and I can confirm the issue as you described in your first comment:
we have a parent element with .container class and the action bar (only that) is hidden.

I'm trying to fix it, and changing the position: absolute rule to position: relative for the :after seems to be working. I have the following override at the moment:

.container {
  .bcl-content-banner {
    &.bg-lighter {
      &:after {
        position: relative;
      }
    }
  }
}

I will come back with an update if this fix works out for our project (so far it looks ok, but we are still testing/reviewing it).

Note: this new rule that's causing the issue was added as a solution to #517 (reported by us originally, as we have a parent .container). That issue with the margin is solved by the fix, but there is this regression now with the hidden action bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants