-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: request error for empty user list responses #290
fix: request error for empty user list responses #290
Conversation
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #290 +/- ##
============================================================
Coverage 100.00% 100.00%
============================================================
Files 110 110
Lines 1079 1080 +1
Branches 159 160 +1
============================================================
+ Hits 1079 1080 +1 ☔ View full report in Codecov by Sentry. |
Hi @openedx/content-aurora! This is ready once the master is all set. |
Marking as draft until the fix is merged to master. |
6d341d4
to
a643cae
Compare
a643cae
to
56b0922
Compare
56b0922
to
8e3f8dd
Compare
Hi, @arbrandes |
Hi @jansenk! Are you able to merge this for us? |
Hello @jansenk, could you help us merge this PR? I don't have write permissions for this repo, so I can't. |
Hey @DmytroAlipov and @mariajgrimaldi, is this backport still needed? |
@itsjeyd hi |
@DmytroAlipov OK, I'll close it then. Thank you for the quick reply! |
This is backport from the master.
Description:
"An unexpected error occurred" if you try to get all responses when the users' list is empty:
I suggest not sending a request if the users are not on the list.